Thrift
  1. Thrift
  2. THRIFT-1037

Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: C# - Compiler, C# - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      I've made some changes to the C# compiler and library to support Silverlight and Windows Phone 7. I'd appreciate other people's thoughts before I submit a patch.

      The changes are described and available here: http://damianblog.com/2011/01/11/generating-silverlight-windows-phone-compatible-thrift-proxies/

      If you'd prefer that I submit a patch first then no problem.

      Thanks,
      Damian

        Activity

        Hide
        Roger Meier added a comment -

        Cool! There are several users that look for that feature.

        Yes, please submit a patch. see: http://wiki.apache.org/thrift/HowToContribute

        Show
        Roger Meier added a comment - Cool! There are several users that look for that feature. Yes, please submit a patch. see: http://wiki.apache.org/thrift/HowToContribute
        Hide
        Jens Geyer added a comment -

        With permission from Damian, I provide this patch which is mostly based on Damian's modifications to both C# library and compiler. I took the files he had published on his blog.

        I made only some further minor modifications to it:

        What is still missing:

        • The MSBuildTask has not been changed. I have no opportunity to test that and would like to leave this task to someone else who can.
        Show
        Jens Geyer added a comment - With permission from Damian, I provide this patch which is mostly based on Damian's modifications to both C# library and compiler. I took the files he had published on his blog. I made only some further minor modifications to it: added a new "async" switch which generates code in order to support the AsyncCTP v3. (see http://www.microsoft.com/download/en/details.aspx?id=9983 ) added a new project file for a separate Thrift.WP7 assembly What is still missing: The MSBuildTask has not been changed. I have no opportunity to test that and would like to leave this task to someone else who can.
        Hide
        Roger Meier added a comment -

        committed!

        Thanks Damian for initial efforts and Jens for integration work!

        -roger

        Show
        Roger Meier added a comment - committed! Thanks Damian for initial efforts and Jens for integration work! -roger
        Hide
        Hudson added a comment -

        Integrated in Thrift #353 (See https://builds.apache.org/job/Thrift/353/)
        THRIFT-1037 Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3
        Patch: Damian Mehers & Jens Geyer

        roger : http://svn.apache.org/viewvc/?view=rev&rev=1211880
        Files :

        • /thrift/trunk/compiler/cpp/src/generate/t_csharp_generator.cc
        • /thrift/trunk/lib/csharp/src/Collections/THashSet.cs
        • /thrift/trunk/lib/csharp/src/Properties/AssemblyInfo.WP7.cs
        • /thrift/trunk/lib/csharp/src/Protocol/TBinaryProtocol.cs
        • /thrift/trunk/lib/csharp/src/Protocol/TJSONProtocol.cs
        • /thrift/trunk/lib/csharp/src/Protocol/TProtocol.cs
        • /thrift/trunk/lib/csharp/src/Thrift.WP7.csproj
        • /thrift/trunk/lib/csharp/src/Transport/THttpClient.cs
        • /thrift/trunk/lib/csharp/src/Transport/TTransport.cs
        Show
        Hudson added a comment - Integrated in Thrift #353 (See https://builds.apache.org/job/Thrift/353/ ) THRIFT-1037 Proposed changes to support Silverlight, Windows Phone and AsyncCTP v3 Patch: Damian Mehers & Jens Geyer roger : http://svn.apache.org/viewvc/?view=rev&rev=1211880 Files : /thrift/trunk/compiler/cpp/src/generate/t_csharp_generator.cc /thrift/trunk/lib/csharp/src/Collections/THashSet.cs /thrift/trunk/lib/csharp/src/Properties/AssemblyInfo.WP7.cs /thrift/trunk/lib/csharp/src/Protocol/TBinaryProtocol.cs /thrift/trunk/lib/csharp/src/Protocol/TJSONProtocol.cs /thrift/trunk/lib/csharp/src/Protocol/TProtocol.cs /thrift/trunk/lib/csharp/src/Thrift.WP7.csproj /thrift/trunk/lib/csharp/src/Transport/THttpClient.cs /thrift/trunk/lib/csharp/src/Transport/TTransport.cs
        Hide
        Damian Mehers added a comment -

        Just a quick comment to confirm my approval of Jens' work submitting this patch - thanks Jens!

        Damian

        Show
        Damian Mehers added a comment - Just a quick comment to confirm my approval of Jens' work submitting this patch - thanks Jens! Damian

          People

          • Assignee:
            Jens Geyer
            Reporter:
            Damian Mehers
          • Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development