[THRIFT-1036] Auto-generated C++ code fails to compile with "-Werror -Wextra -Wall" g++ compiler flags

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.7
• Fix Version/s: 0.7
• Component/s: C++ - Compiler

Environment

OS: FreeBSD-8.0
Compiler: g++ (GCC) 4.2.1 20070719 [FreeBSD]

• Patch Info: Patch Available
• Assignee: Roger Meier
• Reporter: Pavlin Radoslavov
• Created: 11/Jan/11 08:18
• Updated: 09/Mar/11 18:17
• Resolved: 23/Jan/11 09:36

Description

If the following command is used to auto-generate the C++ code
thrift --gen cpp:cob_style foo.thrift
then some of the auto-generated code contains the following:

class FooCobClient : virtual public FooCobClIf {
...
virtual void completed__(bool success) {}
...
};

The above code fails to compile if we use g++ with the "-Werror -Wextra -Wall" compiler options:
gen-cpp/Foo.h:767: warning: unused parameter 'success'

The solution is trivial: just comment-out the unused "success" argument when the code is
auto-generated (see attached patch).