[THRIFT-1011] Error generating package imports when using classes from other packages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.1, 0.2, 0.3, 0.4, 0.5
• Fix Version/s: 0.7
• Component/s: AS3 - Compiler

Environment

All Environments

• Patch Info: Patch Available
• Assignee: Usman Ismail
• Reporter: Usman Ismail
• Created: 30/Nov/10 18:59
• Updated: 01/Mar/11 16:59
• Resolved: 01/Mar/11 16:59

Description

If you define multiple thrift files and use a data type from one file in another the generated code is broken because it tries to use the fully qualified class name as object type without adding an import call. While this works in java it does not work in as3.

For example, if we have a file types.thrift

******types.thrift***********
namespace com.xxx.xxx.types

struct Type1 {
1: string param1,
}

********************************

and a file service.thrift

**********service.thrift*********
namespace com.xxx.xxx.services

include "types.thrift"
service Service1 {
void method (1:types.Type1 object),
}
********************************

This will generate a method definition like

public function method(object:com.xxx.xxx.types.Type1, onError:Function, onSuccess:Function):void

but will not generate the import
import :com.xxx.xxx.types.Type1;