[TEZ-4413] Fix permission may not be set after crash

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.5
• Assignee: Ayush Saxena
• Reporter: lujie
• Created: 14/May/22 13:09
• Updated: 06/Sep/24 12:38
• Resolved: 06/Sep/24 12:38

Description

the code  in createDirIfNotExists:

 

 

  private void createDirIfNotExists(Path path) throws IOException {
    FileSystem fileSystem = path.getFileSystem(conf);
    try {
      if (!fileSystem.exists(path)) {
        fileSystem.mkdirs(path);
        fileSystem.setPermission(path, DIR_PERMISSION);
      }
    } catch (IOException e) {
      // Ignore this exception, if there is a problem it'll fail when trying to read or write.
      LOG.warn("Error while trying to set permission: ", e);
    }
  }

 

but if the node crash between mkdirs and setPermission, the permisson will not be set forever even reboot.

 

So how about change the code like 

 

 

  private void createDirIfNotExists(Path path) throws IOException {
    FileSystem fileSystem = path.getFileSystem(conf);
    try {
      if (!fileSystem.exists(path)) {
        fileSystem.mkdirs(path);
       
      }
         fileSystem.setPermission(path, DIR_PERMISSION);
     } catch (IOException e) {
      // Ignore this exception, if there is a problem it'll fail when trying to read or write.
      LOG.warn("Error while trying to set permission: ", e);
    }
  } 

 

 

 

Issue Links

• links to: GitHub Pull Request #298
• links to: GitHub Pull Request #368