Major Description
Looking at the progress code, there some few issues that could lead to some problems calculating the progress.
There are some cases when the progress never reach 1.0.
This is a list of issues that need to be fixed in the progress code:
- After
TEZ-3982, since values are skipped in the In some cases, the progress of DAG or a vertex may never reach 1.0f. this is in both "DAGImpl.java" and "ProgressHelper.java" - ProgressHelper schedules a service to update the progress, dubbed `ProgressHelper.monitorProgress`. According to Java Documentation:
If any execution of the task encounters an exception,
subsequent executions are suppressed.
Otherwise, the task will only terminate via cancellation
or termination of the executor.In other words, if the service dies, there is no way to catch that in the code and the progress will never be updated.
- The `SimpleProcessor.inputMap` is not thread-safe. They are initialized as `LinkedHashMap` and there is no synchronization on the field objects in the map. This could be problematic in concurrent context.
- `VertexImpl.getProgress()` does not check the range of the progress calculated in `VertexImpl.computeProgress()`