[TEZ-3969] TaskAttemptImpl: static fields initialized in instance ctor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9.2, 0.10.0
• Assignee: Jaume M
• Reporter: Gopal Vijayaraghavan
• Created: 09/Jul/18 23:20
• Updated: 19/Apr/19 19:21
• Resolved: 09/Oct/18 18:16

Description

The TODO is probably well-placed (& the bug looks somewhat intentional to minimize the size of TaskAttemptImpl object).

This isn't causing any bugs at the moment, because the block is called from the same thread always.

public TaskAttemptImpl(TezTaskAttemptID attemptId, EventHandler eventHandler,
 ...
    // TODO: Move these configs over to Vertex.VertexConfig
    MAX_ALLOWED_OUTPUT_FAILURES = conf.getInt(TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES, TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_DEFAULT);

    MAX_ALLOWED_OUTPUT_FAILURES_FRACTION = conf.getDouble(TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION, TezConfiguration
        .TEZ_TASK_MAX_ALLOWED_OUTPUT_FAILURES_FRACTION_DEFAULT);
    
    MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC = conf.getInt(
        TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC,
        TezConfiguration.TEZ_AM_MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC_DEFAULT);

But these fields are static members of the class & this is excluded in the findbugs to avoid warnings.

  private static double MAX_ALLOWED_OUTPUT_FAILURES_FRACTION;
  private static int MAX_ALLOWED_OUTPUT_FAILURES;
  private static int MAX_ALLOWED_TIME_FOR_TASK_READ_ERROR_SEC;