Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2900

Ignore V_INPUT_DATA_INFORMATION when vertex is in Failed/Killed/Error

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.7.1, 0.8.2
    • None
    • None

    Description

      https://builds.apache.org/job/Tez-Build-Hadoop-2.2/191/console

      Tests run: 91, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 8.003 sec <<< FAILURE!
      testVertexWithInitializerFailure(org.apache.tez.dag.app.dag.impl.TestVertexImpl)  Time elapsed: 0.053 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<FAILED> but was:<ERROR>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:144)
      	at org.apache.tez.dag.app.dag.impl.TestVertexImpl.testVertexWithInitializerFailure(TestVertexImpl.java:4207)
      
      Running org.apache.tez.dag.app.dag.impl.TestTaskAttempt
      Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.589 sec
      Running org.apache.tez.dag.app.dag.impl.TestDAGImpl
      Tests run: 35, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 13.502 sec <<< FAILURE!
      testGetDAGStatusReturnOnDagFailed(org.apache.tez.dag.app.dag.impl.TestDAGImpl)  Time elapsed: 1.756 sec  <<< FAILURE!
      java.lang.AssertionError: expected:<5> but was:<4>
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.junit.Assert.failNotEquals(Assert.java:743)
      	at org.junit.Assert.assertEquals(Assert.java:118)
      	at org.junit.Assert.assertEquals(Assert.java:555)
      	at org.junit.Assert.assertEquals(Assert.java:542)
      	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.runTestGetDAGStatusReturnOnDagFinished(TestDAGImpl.java:1774)
      	at org.apache.tez.dag.app.dag.impl.TestDAGImpl.testGetDAGStatusReturnOnDagFailed(TestDAGImpl.java:1745)
      

      Attachments

        1. TEZ-2900-1.patch
          2 kB
          Jeff Zhang

        Activity

          zjffdu Jeff Zhang added a comment -

          Change the title.

          • TestVertexImpl#testVertexWithInitializerFailure
            • This unit test fails is due to the state machine error in VertexImpl.
          • TestDAGImpl#testGetDAGStatusReturnOnDagFailed
            • This should due to the race issue DrainDispatcher (YARN-2264) which has been fixed in hadoop 2.6. (Only see this unit test failure under hadoop 2.2)
          zjffdu Jeff Zhang added a comment - Change the title. TestVertexImpl#testVertexWithInitializerFailure This unit test fails is due to the state machine error in VertexImpl. TestDAGImpl#testGetDAGStatusReturnOnDagFailed This should due to the race issue DrainDispatcher ( YARN-2264 ) which has been fixed in hadoop 2.6. (Only see this unit test failure under hadoop 2.2)
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12767749/TEZ-2900-1.patch
          against master revision d336ebd.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in :
          org.apache.tez.dag.app.rm.TestContainerReuse

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/1237//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1237//console

          This message is automatically generated.

          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12767749/TEZ-2900-1.patch against master revision d336ebd. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.dag.app.rm.TestContainerReuse Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/1237//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/1237//console This message is automatically generated.
          zjffdu Jeff Zhang added a comment -

          bikassaha Please help review it.

          zjffdu Jeff Zhang added a comment - bikassaha Please help review it.
          bikassaha Bikas Saha added a comment -

          lgtm

          bikassaha Bikas Saha added a comment - lgtm
          zjffdu Jeff Zhang added a comment -

          Committed to 0.7 & master

          zjffdu Jeff Zhang added a comment - Committed to 0.7 & master
          hitesh Hitesh Shah added a comment -

          Closing as 0.7.1 released.

          hitesh Hitesh Shah added a comment - Closing as 0.7.1 released.

          People

            zjffdu Jeff Zhang
            zjffdu Jeff Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: