[TEZ-2755] Fix findbugs warning in TezClient

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.7.1, 0.8.1-alpha
• Target Version/s: 0.7.1
• Assignee: Jonathan Turner Eagles
• Reporter: Jonathan Turner Eagles
• Created: 31/Aug/15 16:37
• Updated: 12/Oct/15 20:46
• Resolved: 02/Sep/15 20:32

Description

Multithreaded correctness Warnings
Code 	Warning
SWL 	org.apache.tez.client.TezClient.stop() calls Thread.sleep() with a lock held
	

Bug type SWL_SLEEP_WITH_LOCK_HELD (click for details)
In class org.apache.tez.client.TezClient
In method org.apache.tez.client.TezClient.stop()
At TezClient.java:[line 584]
Details
SWL_SLEEP_WITH_LOCK_HELD: Method calls Thread.sleep() with a lock held

This method calls Thread.sleep() with a lock held. This may result in very poor performance and scalability, or a deadlock, since other threads may be waiting to acquire the lock. It is a much better idea to call wait() on the lock, which releases the lock and allows other threads to run. 

Issue Links

• is related to: TEZ-2300 TezClient.stop() takes a lot of time or does not work sometimes