Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2481

Tez UI: graphical view does not render properly on IE11

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.8.0-alpha, 0.7.1
    • None
    • None

    Description

      The issue was because of IE's poor/broken support of css in SVG.

      1. IE doesn't support transform in css like other browsers. This caused the bubbles in a vertex to appear at the origin - https://connect.microsoft.com/IE/feedbackdetail/view/920928
      2. IE have a broken support for the marker(Arrow on the path). This was causing the links/paths to disappear - https://connect.microsoft.com/IE/feedback/details/801938

      Attachments

        1. TEZ-2481.3.patch
          7 kB
          Sreenath Somarajapuram
        2. TEZ-2481.2.patch
          7 kB
          Sreenath Somarajapuram
        3. TEZ-2481.1.patch
          5 kB
          Sreenath Somarajapuram
        4. Screen-Shot-2015-05-25-at-4.02.46-PM.jpg
          58 kB
          Sreenath Somarajapuram

        Activity

          pramachandran Please review the patch.

          Sreenath Sreenath Somarajapuram added a comment - pramachandran Please review the patch.

          Sreenath can you add a comment for the translateIfIE describing the IE bug? not clear on the issue as well as how the magic numbers for translate were arrived.

          pramachandran Prakash Ramachandran added a comment - Sreenath can you add a comment for the translateIfIE describing the IE bug? not clear on the issue as well as how the magic numbers for translate were arrived.
          Sreenath Sreenath Somarajapuram added a comment - - edited

          The issue was because of IE's poor/broken support of css in SVG.

          1. IE doesn't support transform in css like other browsers. This caused the bubbles in a vertex to appear at the origin - https://connect.microsoft.com/IE/feedbackdetail/view/920928
          2. IE have a broken support for the marker(Arrow on the path). This was causing the links/paths to disappear - https://connect.microsoft.com/IE/feedback/details/801938
          Sreenath Sreenath Somarajapuram added a comment - - edited The issue was because of IE's poor/broken support of css in SVG. IE doesn't support transform in css like other browsers. This caused the bubbles in a vertex to appear at the origin - https://connect.microsoft.com/IE/feedbackdetail/view/920928 IE have a broken support for the marker(Arrow on the path). This was causing the links/paths to disappear - https://connect.microsoft.com/IE/feedback/details/801938

          got it.

          basic patch looks good

          • since the CSS and translate in javascript needs to use same values, can you add a comment in both places reminding to update the same? or is it possible to use jquery and get the values from css and update in js?
          • please add a reference to this ticket, without which the translateIE function looks mystical.
          • so on IE the path marker would not be present? is this right?
          • is the css transition property used only for animation? if this is the case can we remove it (I believe less has some support for conditional css)
          pramachandran Prakash Ramachandran added a comment - got it. basic patch looks good since the CSS and translate in javascript needs to use same values, can you add a comment in both places reminding to update the same? or is it possible to use jquery and get the values from css and update in js? please add a reference to this ticket, without which the translateIE function looks mystical. so on IE the path marker would not be present? is this right? is the css transition property used only for animation? if this is the case can we remove it (I believe less has some support for conditional css)
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735002/TEZ-2481.1.patch
          against master revision 87156be.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in :
          org.apache.tez.dag.app.dag.impl.TestVertexImpl

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/732//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/732//console

          This message is automatically generated.

          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735002/TEZ-2481.1.patch against master revision 87156be. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in : org.apache.tez.dag.app.dag.impl.TestVertexImpl Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/732//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/732//console This message is automatically generated.

          Thanks pramachandran
          Please find a fresh patch attached with the comments.

          The translation values are from dag-view.less. As IE doesn't take them from css, we are forced to manually set the same.

          Sreenath Sreenath Somarajapuram added a comment - Thanks pramachandran Please find a fresh patch attached with the comments. The translation values are from dag-view.less. As IE doesn't take them from css, we are forced to manually set the same.
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735004/TEZ-2481.2.patch
          against master revision 87156be.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in :
          org.apache.tez.dag.app.dag.impl.TestVertexImpl

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/733//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/733//console

          This message is automatically generated.

          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735004/TEZ-2481.2.patch against master revision 87156be. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in : org.apache.tez.dag.app.dag.impl.TestVertexImpl Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/733//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/733//console This message is automatically generated.

          Adding one more IE BUG

          Sreenath Sreenath Somarajapuram added a comment - Adding one more IE BUG
          Sreenath Sreenath Somarajapuram added a comment - Splitting and creating a new ticket for mouse issue as that need more time. The ticket is https://issues.apache.org/jira/browse/TEZ-2482 Re submitting patch 2 as the core test failed.
          Sreenath Sreenath Somarajapuram added a comment - - edited

          Attaching screenshot of the graph view from IE.

          Sreenath Sreenath Somarajapuram added a comment - - edited Attaching screenshot of the graph view from IE.

          pramachandran Attaching a fresh patch, please review.

          • The marker wont be visible in IE, also the status wont be visible as the foreign object is also not supported.
          • Have added all the suggested comments.
          Sreenath Sreenath Somarajapuram added a comment - pramachandran Attaching a fresh patch, please review. The marker wont be visible in IE, also the status wont be visible as the foreign object is also not supported. Have added all the suggested comments.
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12735147/TEZ-2481.3.patch
          against master revision 87156be.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/736//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/736//console

          This message is automatically generated.

          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12735147/TEZ-2481.3.patch against master revision 87156be. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/736//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/736//console This message is automatically generated.

          +1 LGTM checked on IE11 and chrome. committing shortly.

          pramachandran Prakash Ramachandran added a comment - +1 LGTM checked on IE11 and chrome. committing shortly.

          committed to master and 0.7.1 thanks Sreenath

          pramachandran Prakash Ramachandran added a comment - committed to master and 0.7.1 thanks Sreenath

          People

            Sreenath Sreenath Somarajapuram
            Sreenath Sreenath Somarajapuram
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: