[TEZ-2413] No need to check whether vertex has been committed as shared output in DAGImpl#vertexreRunning

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Target Version/s: 0.7.2
• Assignee: Jeff Zhang
• Reporter: Jeff Zhang
• Created: 05/May/15 07:23
• Updated: 11/May/16 04:41

Description

• Vertex only send out DAGEventVertexReRunning when vertex.commitVertexOutputs is false, that means it is not necessary to check whether it has been committed as shared output of vertex group in DAGImpl#vertexReRunning

  private boolean vertexReRunning(Vertex vertex) {
      reRunningVertices.add(vertex.getVertexId());
      numSuccessfulVertices--;
      addDiagnostic("Vertex re-running"
        + ", vertexName=" + vertex.getName()
        + ", vertexId=" + vertex.getVertexId());
  
      if (!commitAllOutputsOnSuccess) {
        // partial output may already have been committed. fail if so
        List<VertexGroupInfo> groupList = vertexGroupInfo.get(vertex.getName());
        if (groupList != null) {
          for (VertexGroupInfo groupInfo : groupList) {
            if (groupInfo.committed) {
              String msg = "Aborting job as committed vertex: "
                  + vertex.getLogIdentifier() + " is re-running";
              LOG.info(msg);
              addDiagnostic(msg);
              enactKill(DAGTerminationCause.VERTEX_RERUN_AFTER_COMMIT,
                  VertexTerminationCause.VERTEX_RERUN_AFTER_COMMIT);
              return true;
            } else {
              groupInfo.successfulMembers--;
            }
          }
        }
      }