Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2158

TEZ UI: Display dag/vertex names, and task/attempt index in breadcrumb

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None
    1. TEZ-2158.1.patch
      12 kB
      Sreenath Somarajapuram
    2. TEZ-2158.2.patch
      14 kB
      Sreenath Somarajapuram

      Activity

      Hide
      hitesh Hitesh Shah added a comment -

      Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

      Show
      hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.
      Hide
      hitesh Hitesh Shah added a comment -

      Thanks Sreenath Somarajapuram. Committed.

      Show
      hitesh Hitesh Shah added a comment - Thanks Sreenath Somarajapuram . Committed.
      Hide
      hitesh Hitesh Shah added a comment -

      Committing shortly.

      Show
      hitesh Hitesh Shah added a comment - Committing shortly.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12701413/TEZ-2158.2.patch
      against master revision 74c3071.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/237//testReport/
      Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/237//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701413/TEZ-2158.2.patch against master revision 74c3071. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/237//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/237//console This message is automatically generated.
      Hide
      hitesh Hitesh Shah added a comment -

      Kicked off precommit build again.

      Show
      hitesh Hitesh Shah added a comment - Kicked off precommit build again.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12701413/TEZ-2158.2.patch
      against master revision 74c3071.

      -1 @author. The patch appears to contain @author tags which the Tez community has agreed to not allow in code contributions.

      +1 tests included. The patch appears to include new or modified test files.

      -1 patch. The patch command could not apply the patch.

      Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/236//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701413/TEZ-2158.2.patch against master revision 74c3071. -1 @author . The patch appears to contain @author tags which the Tez community has agreed to not allow in code contributions. +1 tests included . The patch appears to include new or modified test files. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/236//console This message is automatically generated.
      Hide
      pramachandran Prakash Ramachandran added a comment -

      +1 LGTM

      Show
      pramachandran Prakash Ramachandran added a comment - +1 LGTM
      Hide
      hitesh Hitesh Shah added a comment -

      Comments to be addressed.

      Show
      hitesh Hitesh Shah added a comment - Comments to be addressed.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12701355/TEZ-2158.1.patch
      against master revision 74c3071.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/234//testReport/
      Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/234//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701355/TEZ-2158.1.patch against master revision 74c3071. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/234//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/234//console This message is automatically generated.
      Hide
      pramachandran Prakash Ramachandran added a comment -

      also can we fallback to id for dag/vertex in case name is not available?

      Show
      pramachandran Prakash Ramachandran added a comment - also can we fallback to id for dag/vertex in case name is not available?
      Hide
      pramachandran Prakash Ramachandran added a comment -

      functionality looks fine. few minor comments.

      • task_attempt_controller.js - loadAdditional
        • change tabs to space
        • task id to be displayed can be a computed function instead of loading it. we can avoid an extra hit.
        • vertex and dag loading is currently after loading tasks - better to change to hash/array of promises
      • task_controller.js - same as above
      • task_attempt.js - clarification - should the attempt index be just the attempt number (0) or the task index + attempt (00_0000_0)
      Show
      pramachandran Prakash Ramachandran added a comment - functionality looks fine. few minor comments. task_attempt_controller.js - loadAdditional change tabs to space task id to be displayed can be a computed function instead of loading it. we can avoid an extra hit. vertex and dag loading is currently after loading tasks - better to change to hash/array of promises task_controller.js - same as above task_attempt.js - clarification - should the attempt index be just the attempt number (0) or the task index + attempt (00_0000_0)
      Hide
      Sreenath Sreenath Somarajapuram added a comment -

      Made breadcrumb changes, and added DAG id in DAG details.

      Prakash Ramachandran Please review the patch.

      Show
      Sreenath Sreenath Somarajapuram added a comment - Made breadcrumb changes, and added DAG id in DAG details. Prakash Ramachandran Please review the patch.

        People

        • Assignee:
          Sreenath Sreenath Somarajapuram
          Reporter:
          Sreenath Sreenath Somarajapuram
        • Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development