Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None
    • Target Version/s:

      Description

      Played with the UI for a couple of days. Got some UI enhancements to share.

      1. TEZ-2136.2.patch
        33 kB
        Sreenath Somarajapuram
      2. TEZ-2136-20150223.txt
        30 kB
        Vinod Kumar Vavilapalli

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        Attaching a patch. It does the following

        • Fixed the navigation link on each page to explicitly call out the tab-names. For e.g. DAG Counters instead of Counters.
        • Dag -> DAG everywhere
        • Put Details and Counters links on every page next to each other for consistency.
        • Got rid of the separate tables for IDs on each page - only adds to clutter.
        • Couldn't do the same on the DAG page - I am not able to get the appID link working inside the body
        • Merged the two tables in the Details page into one for readability
        • Added table borders and bold titles for readability
        • Changed the breadcumb to show the IDs clearly.

        Things to do that

        • Fix the DAG page to not have the appID table
        • Move the Refresh icon to the right of breadcrumb. I'd actually propose that we remove this completely and let people rely on the browser refresh. We can show the refresh date though.
        • Whereever we print the list of taskIDs etc (e.g lastTasksToFinish), the list can be further improved (at least removing a trailing pipe).
        • The default landing location of each logical set of pages is still inconsistent - sometimes it is the details page, and sometimes it is the list page.
        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - Attaching a patch. It does the following Fixed the navigation link on each page to explicitly call out the tab-names. For e.g. DAG Counters instead of Counters. Dag -> DAG everywhere Put Details and Counters links on every page next to each other for consistency. Got rid of the separate tables for IDs on each page - only adds to clutter. Couldn't do the same on the DAG page - I am not able to get the appID link working inside the body Merged the two tables in the Details page into one for readability Added table borders and bold titles for readability Changed the breadcumb to show the IDs clearly. Things to do that Fix the DAG page to not have the appID table Move the Refresh icon to the right of breadcrumb. I'd actually propose that we remove this completely and let people rely on the browser refresh. We can show the refresh date though. Whereever we print the list of taskIDs etc (e.g lastTasksToFinish), the list can be further improved (at least removing a trailing pipe). The default landing location of each logical set of pages is still inconsistent - sometimes it is the details page, and sometimes it is the list page.
        Hide
        hitesh Hitesh Shah added a comment - - edited
        Show
        hitesh Hitesh Shah added a comment - - edited Sreenath Somarajapuram Prakash Ramachandran Mind taking a look?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700286/TEZ-2136-20150223.txt
        against master revision c9a74d7.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/221//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/221//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700286/TEZ-2136-20150223.txt against master revision c9a74d7. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/221//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/221//console This message is automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thank you so much Vinod Kumar Vavilapalli

        Attaching a fresh patch with fixes for the following observed issues.
        1. Link to RM from application was broken by the move.
        2. Bottom and right borders of details table was not displayed.
        3. DAG details : Moved application link to table.
        4. Diagnostics box and table wasn't having separation in between.
        5. Breadcrumb: Task Attempt id font was small.
        6. Broken breadcrumb in tasks page on clicking failed tasks in DAG details
        7. Vertex details: Delimiter '|' getting displayed at the end of tasks list.

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thank you so much Vinod Kumar Vavilapalli Attaching a fresh patch with fixes for the following observed issues. 1. Link to RM from application was broken by the move. 2. Bottom and right borders of details table was not displayed. 3. DAG details : Moved application link to table. 4. Diagnostics box and table wasn't having separation in between. 5. Breadcrumb: Task Attempt id font was small. 6. Broken breadcrumb in tasks page on clicking failed tasks in DAG details 7. Vertex details: Delimiter '|' getting displayed at the end of tasks list. Prakash Ramachandran Please review the patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12700493/TEZ-2136.2.patch
        against master revision c78feed.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/222//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/222//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700493/TEZ-2136.2.patch against master revision c78feed. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/222//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/222//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        checked the patch 2 - LGTM.

        Show
        pramachandran Prakash Ramachandran added a comment - checked the patch 2 - LGTM.
        Hide
        venkateshrin Ram Venkatesh added a comment -

        Verified that the changes apply cleanly within the Tez Ambari view also. LGTM

        Show
        venkateshrin Ram Venkatesh added a comment - Verified that the changes apply cleanly within the Tez Ambari view also. LGTM
        Hide
        hitesh Hitesh Shah added a comment -
        Show
        hitesh Hitesh Shah added a comment - Thanks Vinod Kumar Vavilapalli and Sreenath Somarajapuram . Committed.
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            vinodkv Vinod Kumar Vavilapalli
            Reporter:
            vinodkv Vinod Kumar Vavilapalli
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development