Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2102

Tez UI: DAG view has hidden edges, dragging DAG by holding vertex causes unintended click

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None

      Description

      1. The treed width calculated is not correct causing the vertices to appear very near to each other in some of the dags.
      2. Disables click even on drag.
      3. Tooltips with large values wasn't appearing properly.
      4. Added linkDelta to make inward links look better in both orientations.

      1. TEZ-2102.1.patch
        2 kB
        Sreenath Somarajapuram
      2. TEZ-2102.2.patch
        3 kB
        Sreenath Somarajapuram
      3. TEZ-2102.3.patch
        5 kB
        Sreenath Somarajapuram

        Issue Links

          Activity

          Hide
          hitesh Hitesh Shah added a comment -

          Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          Show
          hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.
          Hide
          hitesh Hitesh Shah added a comment -

          Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram

          Show
          hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram
          Hide
          pramachandran Prakash Ramachandran added a comment -

          +1 lgtm , tested with the pig dag which had the issue.

          Show
          pramachandran Prakash Ramachandran added a comment - +1 lgtm , tested with the pig dag which had the issue.
          Hide
          hitesh Hitesh Shah added a comment -

          Prakash Ramachandran Mind taking a look at this patch too?

          Show
          hitesh Hitesh Shah added a comment - Prakash Ramachandran Mind taking a look at this patch too?
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Jonathan Eagles Please review the patch.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Jonathan Eagles Please review the patch.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12698741/TEZ-2102.3.patch
          against master revision 8e8405b.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/190//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/190//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/190//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698741/TEZ-2102.3.patch against master revision 8e8405b. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/190//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/190//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/190//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12698736/TEZ-2102.2.patch
          against master revision 8e8405b.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/189//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/189//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/189//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698736/TEZ-2102.2.patch against master revision 8e8405b. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/189//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/189//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/189//console This message is automatically generated.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          1. Disables click even on drag.
          2. A missing px in css was causing an issue when tooltip have very large value.
          3. Added linkDelta to make inward links look better in both orientations.

          Show
          Sreenath Sreenath Somarajapuram added a comment - 1. Disables click even on drag. 2. A missing px in css was causing an issue when tooltip have very large value. 3. Added linkDelta to make inward links look better in both orientations.
          Hide
          pramachandran Prakash Ramachandran added a comment -

          one another issue unrelated to the patch is the drag behavior, if its not too much effort is it possible to fix that one to?

          Show
          pramachandran Prakash Ramachandran added a comment - one another issue unrelated to the patch is the drag behavior, if its not too much effort is it possible to fix that one to?
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Prakash Ramachandran Please review the patch.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Prakash Ramachandran Please review the patch.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Plugged a variable leak.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Plugged a variable leak.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Until now number of inputs was used to calculate the width. Changing to leaf count as it gives a better width for plotting the graph.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Until now number of inputs was used to calculate the width. Changing to leaf count as it gives a better width for plotting the graph.

            People

            • Assignee:
              Sreenath Sreenath Somarajapuram
              Reporter:
              Sreenath Sreenath Somarajapuram
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development