Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None

      Description

      1. getStatusClassForEntity was getting called with an undefined value.
      2. The error "TypeError: undefined is not an object (evaluating 'container.offset().top')" is getting thrown on opening any page after dag view. Its because a window resize listener isn't relinquished.
      3. Border as extending down on opening a table without any rows.

      1. TEZ-2101.1.patch
        1 kB
        Sreenath Somarajapuram

        Activity

        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Prakash Ramachandran Please review the patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698693/TEZ-2101.1.patch
        against master revision b26fdfe.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/188//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/188//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/188//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698693/TEZ-2101.1.patch against master revision b26fdfe. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/188//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/188//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/188//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 LGTM

        Show
        pramachandran Prakash Ramachandran added a comment - +1 LGTM
        Hide
        hitesh Hitesh Shah added a comment -

        Committing shortly.

        Show
        hitesh Hitesh Shah added a comment - Committing shortly.
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development