Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2079

Tez UI: trailing slash in timelineBaseUrl in ui should be handled

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None
    • Target Version/s:

      Description

      trailing / in timelineBaseUrl is not handled properly.

      1. TEZ-2079.1.patch
        0.6 kB
        Prakash Ramachandran

        Activity

        Hide
        pramachandran Prakash Ramachandran added a comment -

        trivial patch Sreenath Somarajapuram review please

        Show
        pramachandran Prakash Ramachandran added a comment - trivial patch Sreenath Somarajapuram review please
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        +1 LGTM

        Show
        Sreenath Sreenath Somarajapuram added a comment - +1 LGTM
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698083/TEZ-2079.1.patch
        against master revision b336ca0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/165//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/165//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698083/TEZ-2079.1.patch against master revision b336ca0. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/165//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/165//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        +1

        Show
        hitesh Hitesh Shah added a comment - +1
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            pramachandran Prakash Ramachandran
            Reporter:
            pramachandran Prakash Ramachandran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development