Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2065

Setting up tez.tez-ui.history-url.base with a trailing slash can result in failures to redirect correctly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None
    • Target Version/s:

      Description

      Given that the default value of tez.am.tez-ui.history-url.template is "_HISTORY_URL_BASE/#/tez-app/APPLICATION_ID_", this can create problems at times due to the "//" if tez.tez-ui.history-url.base is configured with a trailing slash.

      1. TEZ-2065.2.patch
        2 kB
        Prakash Ramachandran
      2. TEZ-2065.1.patch
        0.8 kB
        Prakash Ramachandran

        Activity

        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Prakash Ramachandran

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Prakash Ramachandran
        Hide
        hitesh Hitesh Shah added a comment -

        +1. Test failure addressed by patch in TEZ-2068

        Show
        hitesh Hitesh Shah added a comment - +1. Test failure addressed by patch in TEZ-2068
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698125/TEZ-2065.2.patch
        against master revision b336ca0.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in :
        org.apache.tez.dag.app.TestMockDAGAppMaster

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/167//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/167//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698125/TEZ-2065.2.patch against master revision b336ca0. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.dag.app.TestMockDAGAppMaster Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/167//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/167//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Furthermore what happens if someone overrides the template to not have a "/" at the beginning?

        Show
        hitesh Hitesh Shah added a comment - Furthermore what happens if someone overrides the template to not have a "/" at the beginning?
        Hide
        hitesh Hitesh Shah added a comment -

        An additional unit test to catch this would be good.

        Show
        hitesh Hitesh Shah added a comment - An additional unit test to catch this would be good.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        The unit test failure is unrelated and is being tracked in TEZ-2058

        Show
        pramachandran Prakash Ramachandran added a comment - The unit test failure is unrelated and is being tracked in TEZ-2058
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12697656/TEZ-2065.1.patch
        against master revision 12c31ab.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in :
        org.apache.tez.test.TestTezJobs

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/154//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/154//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697656/TEZ-2065.1.patch against master revision 12c31ab. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.test.TestTezJobs Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/154//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/154//console This message is automatically generated.

          People

          • Assignee:
            pramachandran Prakash Ramachandran
            Reporter:
            hitesh Hitesh Shah
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development