Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2056

Tez UI: fix VertexID filter,show only tez configs by default,fix appattemptid

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      • Searching by a vertexId is broken on dag tasks view.
      • Configuration shows all settings in alphabetical order instead of showing only tez.* at the top
      • When status is not Finished, app attempt id shows up with a "-"
      1. TEZ-2056.2.patch
        7 kB
        Prakash Ramachandran
      2. TEZ-2056.1.patch
        7 kB
        Prakash Ramachandran

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12697228/TEZ-2056.1.patch
        against master revision 2b5eeea.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/142//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/142//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697228/TEZ-2056.1.patch against master revision 2b5eeea. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/142//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/142//console This message is automatically generated.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Trailing space in dag_tasks.js
        Its not ideal to use id for styling.
        display doesn't have a property value hidden, better to use .no-display class from shared.less to hide.

        When the text box is in focus, bootstrap adds a blue hallow. input-wrapper is clipping this to the left, top and bottom leaving a blue line to the right, making the ui look unfinished.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Trailing space in dag_tasks.js Its not ideal to use id for styling. display doesn't have a property value hidden, better to use .no-display class from shared.less to hide. When the text box is in focus, bootstrap adds a blue hallow. input-wrapper is clipping this to the left, top and bottom leaving a blue line to the right, making the ui look unfinished.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        addressed review comments

        Show
        pramachandran Prakash Ramachandran added a comment - addressed review comments
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        +1 LGTM

        Show
        Sreenath Sreenath Somarajapuram added a comment - +1 LGTM
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12697256/TEZ-2056.2.patch
        against master revision 2b5eeea.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in :
        org.apache.tez.test.TestTezJobs

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/143//testReport/
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/143//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697256/TEZ-2056.2.patch against master revision 2b5eeea. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in : org.apache.tez.test.TestTezJobs Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/143//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/143//console This message is automatically generated.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        cancelling just to get pre-commit build

        Show
        pramachandran Prakash Ramachandran added a comment - cancelling just to get pre-commit build
        Hide
        pramachandran Prakash Ramachandran added a comment -

        submitting for pre-commit build

        Show
        pramachandran Prakash Ramachandran added a comment - submitting for pre-commit build
        Hide
        hitesh Hitesh Shah added a comment -

        +1. Committing shortly.

        Show
        hitesh Hitesh Shah added a comment - +1. Committing shortly.
        Hide
        hitesh Hitesh Shah added a comment - - edited

        Unit test failure is unrelated. Filed TEZ-2058.

        Show
        hitesh Hitesh Shah added a comment - - edited Unit test failure is unrelated. Filed TEZ-2058 .
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Prakash Ramachandran and Sreenath Somarajapuram
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            pramachandran Prakash Ramachandran
            Reporter:
            pramachandran Prakash Ramachandran
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development