Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2038

TEZ-UI DAG is always running in tez-ui when the app is failed but no DAGFinishedEvent is logged

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None
    • Target Version/s:

      Description

      If AM crashed before DAG is finished, there wouldn't be DAGFinishedEvent. In this case, DAG is always shown as running in tez-ui, but the yarn application is actually finished.

      1. TEZ-2038.1.patch
        8 kB
        Prakash Ramachandran
      2. TEZ-2038.2.patch
        8 kB
        Prakash Ramachandran
      3. TEZ-2038.3.patch
        10 kB
        Prakash Ramachandran
      4. TEZ-2038.4.patch
        10 kB
        Prakash Ramachandran

        Issue Links

          Activity

          Hide
          pramachandran Prakash Ramachandran added a comment - - edited

          Sreenath Somarajapuram can you review. did basic testing

          Show
          pramachandran Prakash Ramachandran added a comment - - edited Sreenath Somarajapuram can you review. did basic testing
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          The patch is not clean, its failing in main.less.

          Show
          Sreenath Sreenath Somarajapuram added a comment - The patch is not clean, its failing in main.less.
          Hide
          pramachandran Prakash Ramachandran added a comment -

          attaching patch after resolving the conflict.

          Show
          pramachandran Prakash Ramachandran added a comment - attaching patch after resolving the conflict.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Status must also be corrected in dags table under application.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Status must also be corrected in dags table under application.
          Hide
          pramachandran Prakash Ramachandran added a comment -

          thanks Sreenath Somarajapuram attaching patch with review comment fixed

          Show
          pramachandran Prakash Ramachandran added a comment - thanks Sreenath Somarajapuram attaching patch with review comment fixed
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          1. Trailing space in tez-app-dags-controller.js

          2. yarnAppState added by 2078 is getting removed from dag_controller.js. That would break the fix.

          • var appDetailFetcher = that.store.find('appDetail', applicationId).then(function(appDetail) {
          • var appState = appDetail.get('appState');
          • if (appState) { - that.set('yarnAppState', appState); - }
          • });
          • loaders.push(appDetailFetcher);
          Show
          Sreenath Sreenath Somarajapuram added a comment - 1. Trailing space in tez-app-dags-controller.js 2. yarnAppState added by 2078 is getting removed from dag_controller.js. That would break the fix. var appDetailFetcher = that.store.find('appDetail', applicationId).then(function(appDetail) { var appState = appDetail.get('appState'); if (appState) { - that.set('yarnAppState', appState); - } }); loaders.push(appDetailFetcher);
          Hide
          pramachandran Prakash Ramachandran added a comment -

          Sreenath Somarajapuram the yarnAppState is being set. the code was fetching the appDetails twice and I removed the duplicate loading and moved it to a common place.

          Show
          pramachandran Prakash Ramachandran added a comment - Sreenath Somarajapuram the yarnAppState is being set. the code was fetching the appDetails twice and I removed the duplicate loading and moved it to a common place.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Sorry, my bad.

          +1 LGTM

          Show
          Sreenath Sreenath Somarajapuram added a comment - Sorry, my bad. +1 LGTM
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12699046/TEZ-2038.4.patch
          against master revision a5a5665.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/194//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/194//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699046/TEZ-2038.4.patch against master revision a5a5665. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/194//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/194//console This message is automatically generated.
          Hide
          zjffdu Jeff Zhang added a comment - - edited

          On behalf of Prakash Ramachandran Committed to master & branch-0.6

          Show
          zjffdu Jeff Zhang added a comment - - edited On behalf of Prakash Ramachandran Committed to master & branch-0.6
          Hide
          hitesh Hitesh Shah added a comment -

          Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          Show
          hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

            People

            • Assignee:
              pramachandran Prakash Ramachandran
              Reporter:
              zjffdu Jeff Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development