Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2037

Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.5.4
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      In the tez-ui, there's no available information about taskattempt that is recovered to KILLED , it it because of there' s no TaskAttemptFinsihedEvent in this case.

      1. TEZ-2037-1.patch
        6 kB
        Jeff Zhang
      2. task_attempt.png
        58 kB
        Jeff Zhang

        Activity

        Hide
        zjffdu Jeff Zhang added a comment -

        Attach screenshot.

        Show
        zjffdu Jeff Zhang added a comment - Attach screenshot.
        Hide
        zjffdu Jeff Zhang added a comment - - edited

        Hitesh Shah Split out TEZ-2037 related patch to here and target this jira to 0.5.4
        Will update the patch on TEZ-2024 after this is committed because they they share some common code in unit test.

        Show
        zjffdu Jeff Zhang added a comment - - edited Hitesh Shah Split out TEZ-2037 related patch to here and target this jira to 0.5.4 Will update the patch on TEZ-2024 after this is committed because they they share some common code in unit test.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698344/TEZ-2037-1.patch
        against master revision 54bd104.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/179//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/179//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/179//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698344/TEZ-2037-1.patch against master revision 54bd104. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/179//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/179//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/179//console This message is automatically generated.
        Hide
        zjffdu Jeff Zhang added a comment -

        Siddharth Seth Is the new findbugs due to TEZ-2045 ?

        Show
        zjffdu Jeff Zhang added a comment - Siddharth Seth Is the new findbugs due to TEZ-2045 ?
        Hide
        sseth Siddharth Seth added a comment - - edited

        Was introduced in TEZ-2082. Should be a simple enough fix.

        Show
        sseth Siddharth Seth added a comment - - edited Was introduced in TEZ-2082 . Should be a simple enough fix.
        Hide
        zjffdu Jeff Zhang added a comment - - edited

        Committed to master & branch-0.5, branch-0.6, new findbugs warning is due to TEZ-2082

        commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca (HEAD, origin/master, origin/HEAD, master, TEZ-2037)
        Author: Jeff Zhang <zjffdu@apache.org>
        Date: Fri Feb 13 10:01:33 2015 +0800

        TEZ-2037. Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu)

        commit 45167a4cf67c5550f983172acb62c8e48ab1e090 (HEAD, origin/branch-0.5, branch-0.5)
        Author: Jeff Zhang <zjffdu@apache.org>
        Date: Fri Feb 13 10:01:33 2015 +0800

        TEZ-2037. Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu)

        (cherry picked from commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca)

        commit dc2c8dca9effba8a1cf58760c08435f4f6f30535 (HEAD, origin/branch-0.6, branch-0.6)
        Author: Jeff Zhang <zjffdu@apache.org>
        Date: Fri Feb 13 10:01:33 2015 +0800

        TEZ-2037. Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu)

        (cherry picked from commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca)

        Show
        zjffdu Jeff Zhang added a comment - - edited Committed to master & branch-0.5, branch-0.6, new findbugs warning is due to TEZ-2082 commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca (HEAD, origin/master, origin/HEAD, master, TEZ-2037 ) Author: Jeff Zhang <zjffdu@apache.org> Date: Fri Feb 13 10:01:33 2015 +0800 TEZ-2037 . Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu) commit 45167a4cf67c5550f983172acb62c8e48ab1e090 (HEAD, origin/branch-0.5, branch-0.5) Author: Jeff Zhang <zjffdu@apache.org> Date: Fri Feb 13 10:01:33 2015 +0800 TEZ-2037 . Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu) (cherry picked from commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca) commit dc2c8dca9effba8a1cf58760c08435f4f6f30535 (HEAD, origin/branch-0.6, branch-0.6) Author: Jeff Zhang <zjffdu@apache.org> Date: Fri Feb 13 10:01:33 2015 +0800 TEZ-2037 . Should log TaskAttemptFinishedEvent if taskattempt is recovered to KILLED (zjffdu) (cherry picked from commit c266289cde6693e8a586e3c4b2bdffbd6b98b9ca)
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            zjffdu Jeff Zhang
            Reporter:
            zjffdu Jeff Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development