Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-2031

Tez UI: horizontal scrollbars do not appear in tables, causing them to look truncated

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.6.1
    • Component/s: UI
    • Labels:
      None

      Description

      Scrollbar not appearing for tables.
      Also scrolling doesn't happens when mouse is over header cells.
      ~ Cause of default view has truncated columns issue

      1. TEZ-2031.1.patch
        2 kB
        Sreenath Somarajapuram
      2. TEZ-2031.2.patch
        3 kB
        Sreenath Somarajapuram
      3. TEZ-2031.wip.1.patch
        11 kB
        Sreenath Somarajapuram

        Activity

        Hide
        hitesh Hitesh Shah added a comment -

        Sreenath Somarajapuram I don't believe the Ambari view for Tez is in the tez codebase. Does this jira need to be moved to the Ambari project?

        Show
        hitesh Hitesh Shah added a comment - Sreenath Somarajapuram I don't believe the Ambari view for Tez is in the tez codebase. Does this jira need to be moved to the Ambari project?
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Hitesh Shah Action item for these must be executed from inside TEZ view.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Hitesh Shah Action item for these must be executed from inside TEZ view.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Changes for broadcasting tez url change is in progress.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Changes for broadcasting tez url change is in progress.
        Hide
        Sreenath Sreenath Somarajapuram added a comment - - edited

        Content of wip patch was moved to https://issues.apache.org/jira/browse/TEZ-2052.

        Show
        Sreenath Sreenath Somarajapuram added a comment - - edited Content of wip patch was moved to https://issues.apache.org/jira/browse/TEZ-2052 .
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        The fix offloads scrolling control from javascript to the browser, as it should be.
        This is done by removing the js event hooks and making the table occupy the required width, causing the table-container to act as a scrollable container.

        Prakash Ramachandran Please review the patch.

        Show
        Sreenath Sreenath Somarajapuram added a comment - The fix offloads scrolling control from javascript to the browser, as it should be. This is done by removing the js event hooks and making the table occupy the required width, causing the table-container to act as a scrollable container. Prakash Ramachandran Please review the patch.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        patch generally looks fine. one issue is that the width of the table is not recalculated. for ex if i resize a column it would cause the rightmost columns to go out of the visible bounds.

        Show
        pramachandran Prakash Ramachandran added a comment - patch generally looks fine. one issue is that the width of the table is not recalculated. for ex if i resize a column it would cause the rightmost columns to go out of the visible bounds.
        Hide
        Sreenath Sreenath Somarajapuram added a comment -

        Thanks Prakash Ramachandran, please find a new patch that consider column resize.

        Show
        Sreenath Sreenath Somarajapuram added a comment - Thanks Prakash Ramachandran , please find a new patch that consider column resize.
        Hide
        pramachandran Prakash Ramachandran added a comment -

        +1 lgtm

        Show
        pramachandran Prakash Ramachandran added a comment - +1 lgtm
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12698452/TEZ-2031.2.patch
        against master revision 54bd104.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/180//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/180//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html
        Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/180//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12698452/TEZ-2031.2.patch against master revision 54bd104. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/180//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-TEZ-Build/180//artifact/patchprocess/newPatchFindbugsWarningstez-dag.html Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/180//console This message is automatically generated.
        Hide
        hitesh Hitesh Shah added a comment -

        Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran

        Show
        hitesh Hitesh Shah added a comment - Committed to master and branch 0.6. Thanks Sreenath Somarajapuram and Prakash Ramachandran
        Hide
        hitesh Hitesh Shah added a comment -

        Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

        Show
        hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          People

          • Assignee:
            Sreenath Sreenath Somarajapuram
            Reporter:
            Sreenath Sreenath Somarajapuram
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development