Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.7.0
    • Component/s: UI
    • Labels:
      None

      Description

      TEZ-1973 has added a major contribution to the Tez UI. The core of the functionality is there and is committed to community to reduce effort on keeping patch up-to-date and to allow community exposure to the contributions.

      A few fit and finish items have been identified and need to be addressed.

      • Gaussian blur around circles is not a circle (see attachment)
      • Check in checkbox is not centered (see attachment)
      • Success icon is not flush (see attachment)
      • First item in customize vertex should not be selected by default (see attachment)
      • Edge Id name is not correct (see attachment)
      • Double click: was never able to see this working. If functionality is there please update the wording (no attachment)
        Click and drag on graph should not route tez ui to another page (no attachment)
      • Prefer to see dag view view height to extend to bottom of screen (no attachment)
      1. Make source and sink bubble apt for longer text
      2. Bring dag back into view if it go out of view port
      3. Add ellipsis for clipped text in tooltip
      4. Use grab & grabbing cursors to indicate that user can pan the diagram
      5. Put Edge Source Class before Edge Destination Class
      6. BUG-31616 - #3
      7. Make source/sink link tooltip better
      1. Wording and functionality.png
        7 kB
        Jonathan Eagles
      2. TEZ-2016.2.patch
        11 kB
        Sreenath Somarajapuram
      3. TEZ-2016.1.patch
        11 kB
        Sreenath Somarajapuram
      4. Green success icon not flush with edge.png
        6 kB
        Jonathan Eagles
      5. Gaussian Blur is not Radial.png
        10 kB
        Jonathan Eagles
      6. Edge Id name.png
        20 kB
        Jonathan Eagles
      7. Customize vetex should not have first item selected by default.png
        6 kB
        Jonathan Eagles
      8. Check in checkbox is not centered.png
        4 kB
        Jonathan Eagles

        Issue Links

          Activity

          Hide
          jeagles Jonathan Eagles added a comment -

          All items above were tested with firefox 35.0.1

          Show
          jeagles Jonathan Eagles added a comment - All items above were tested with firefox 35.0.1
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Jonathan Eagles Prakash Ramachandran Please review and help to get the patch in.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Jonathan Eagles Prakash Ramachandran Please review and help to get the patch in.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Almost all the individual changes are one liners, hence thought to club them together. Extra items in the patch was added to the description.

          • Gaussian blur: have changed the source and sink into round rects.
          • Check in checkbox is not centered: Will be resolved on changing column selector to a bootstrap model.
          • First item in customize vertex should not be selected by default: Please elaborate, selected items are the default columns displayed in vertex table, and represent the basic data some would be looking for. Should we remove them?
          • Double click: Is the new message good?
          Show
          Sreenath Sreenath Somarajapuram added a comment - Almost all the individual changes are one liners, hence thought to club them together. Extra items in the patch was added to the description. Gaussian blur: have changed the source and sink into round rects. Check in checkbox is not centered: Will be resolved on changing column selector to a bootstrap model. First item in customize vertex should not be selected by default: Please elaborate, selected items are the default columns displayed in vertex table, and represent the basic data some would be looking for. Should we remove them? Double click: Is the new message good?
          Hide
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724879/TEZ-2016.1.patch
          against master revision bd9b8d9.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/452//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/452//console

          This message is automatically generated.

          Show
          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724879/TEZ-2016.1.patch against master revision bd9b8d9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/452//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/452//console This message is automatically generated.
          Hide
          pramachandran Prakash Ramachandran added a comment -
          • please remove the changes in configs.js
          • First item in customize vertex should not be selected by default: Please elaborate, selected items are the default columns displayed in vertex table, and represent the basic data some would be looking for. Should we remove them?

            I think what was meant was that the focus is on the first item. it should not be focused by default.

          Show
          pramachandran Prakash Ramachandran added a comment - please remove the changes in configs.js First item in customize vertex should not be selected by default: Please elaborate, selected items are the default columns displayed in vertex table, and represent the basic data some would be looking for. Should we remove them? I think what was meant was that the focus is on the first item. it should not be focused by default.
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Thanks Prakash Ramachandran.

          • Sorry for the configs.js that creeped in.
          • First item: Have added a line to ensure that the first item wont be focussed by default.
          Show
          Sreenath Sreenath Somarajapuram added a comment - Thanks Prakash Ramachandran . Sorry for the configs.js that creeped in. First item: Have added a line to ensure that the first item wont be focussed by default.
          Hide
          tezqa TezQA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12724923/TEZ-2016.2.patch
          against master revision f719c7b.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/455//testReport/
          Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/455//console

          This message is automatically generated.

          Show
          tezqa TezQA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12724923/TEZ-2016.2.patch against master revision f719c7b. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/455//testReport/ Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/455//console This message is automatically generated.
          Hide
          jeagles Jonathan Eagles added a comment -

          That is correct. If i hit the spacebar it will deselect the first item since that item is in focus.

          Show
          jeagles Jonathan Eagles added a comment - That is correct. If i hit the spacebar it will deselect the first item since that item is in focus.
          Hide
          pramachandran Prakash Ramachandran added a comment -

          +1 LGTM. committing shortly.

          Show
          pramachandran Prakash Ramachandran added a comment - +1 LGTM. committing shortly.
          Hide
          pramachandran Prakash Ramachandran added a comment -

          committed to master . thanks Sreenath Somarajapuram

          Show
          pramachandran Prakash Ramachandran added a comment - committed to master . thanks Sreenath Somarajapuram
          Hide
          Sreenath Sreenath Somarajapuram added a comment -

          Check in checkbox is not centered: Will be resolved on changing column selector to a bootstrap model - TEZ-2312.

          Show
          Sreenath Sreenath Somarajapuram added a comment - Check in checkbox is not centered: Will be resolved on changing column selector to a bootstrap model - TEZ-2312 .
          Hide
          hitesh Hitesh Shah added a comment -

          Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

          Show
          hitesh Hitesh Shah added a comment - Closing issue as 0.5.4, 0.6.1 and 0.7.0 have been released.

            People

            • Assignee:
              Sreenath Sreenath Somarajapuram
              Reporter:
              jeagles Jonathan Eagles
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development