[TEZ-1818] Problem loading tez-api-version-info.properties in case current context classloader in not pointing to Tez jars

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.5.2
• Fix Version/s: 0.5.3
• Assignee: Johannes Zillmann
• Reporter: Johannes Zillmann
• Created: 03/Dec/14 16:37
• Updated: 16/Dec/14 02:59
• Resolved: 04/Dec/14 01:30

Description

TEZ-1664 (0.5.2) introduced loading of tez-api-version-info.properties which is packaged within the tez-api.jar. Its using the current context classloader to load it:

Thread.currentThread().getContextClassLoader()
          .getResourceAsStream(versionInfoFile);

In our environment we load the tez code as a plugin. Our context classloader doesn't have any reference to the Tez code. Thus when instantiating the tez client there is this exception:

 WARN [2014-12-03 17:30:30.971] (VersionInfo.java:60) - Could not read 'tez-api-version-info.properties', java.io.IOException: Resource not found
java.io.IOException: Resource not found
	at org.apache.tez.common.VersionInfo.<init>(VersionInfo.java:56)
	at org.apache.tez.client.TezApiVersionInfo.<init>(TezApiVersionInfo.java:26)
	at org.apache.tez.client.TezClient.<init>(TezClient.java:137)
	at org.apache.tez.client.TezClient.create(TezClient.java:213)
        ....

Is there any specific reason the context classloader is used to load the file ?
Since the properties file is usually bundled within the jar would TezApiVersionInfo.class.getResourceAsStream() not be a better fit ?