Uploaded image for project: 'Apache Tez'
  1. Apache Tez
  2. TEZ-690 Tez API Ease of Use
  3. TEZ-1246

Replace constructors with create() methods for DAG, Vertex, Edge etc in the API

Details

    • Sub-task
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • None
    • 0.5.0
    • None
    • None
    • Incompatible change

    Attachments

      1. TEZ-1246.2.txt
        293 kB
        Siddharth Seth
      2. TEZ-1246.1.txt
        195 kB
        Siddharth Seth

      Issue Links

        Activity

          zjffdu Jeff Zhang added a comment -

          bikassaha do you intend to use builder to create the DAG here ?
          Today I found one issue of DAG that the verify method could not been called multiple times https://issues.apache.org/jira/browse/TEZ-1247
          I think it would be better to use builder here, any thoughts ?

          zjffdu Jeff Zhang added a comment - bikassaha do you intend to use builder to create the DAG here ? Today I found one issue of DAG that the verify method could not been called multiple times https://issues.apache.org/jira/browse/TEZ-1247 I think it would be better to use builder here, any thoughts ?
          sseth Siddharth Seth added a comment -

          I think this change is worth making before 0.5. Gives us some control over evolving DAG, Vertex etc.

          sseth Siddharth Seth added a comment - I think this change is worth making before 0.5. Gives us some control over evolving DAG, Vertex etc.
          sseth Siddharth Seth added a comment -

          Change made for TezClient, DAG, Vertex, Edge, EdgeProperty, UserPayload and a couple other classes.
          Haven't changed EntityDescriptors etc - since I don't think those are critical.

          Also adds Javadoc for some missing methods in Edge, UserPayload.

          bikassaha - review please.

          sseth Siddharth Seth added a comment - Change made for TezClient, DAG, Vertex, Edge, EdgeProperty, UserPayload and a couple other classes. Haven't changed EntityDescriptors etc - since I don't think those are critical. Also adds Javadoc for some missing methods in Edge, UserPayload. bikassaha - review please.
          sseth Siddharth Seth added a comment - - edited

          Also removes version from the InputInitializerEvent constructor, but retains the getter.

          sseth Siddharth Seth added a comment - - edited Also removes version from the InputInitializerEvent constructor, but retains the getter.
          bikassaha Bikas Saha added a comment -

          Missing
          VertexLocationHint
          Would be good to have the above and the *Descriptors change too so that the API looks consistent. Its weird to have a mix.

          What does getVersion() mean in the InputInitializerEvent. Is it event version, attempt version? IMO until TEZ-1447 goes in, this is practically useless. So we could remove it now and add it compatibly later on with a meaningful name, impl etc.

          bikassaha Bikas Saha added a comment - Missing VertexLocationHint Would be good to have the above and the *Descriptors change too so that the API looks consistent. Its weird to have a mix. What does getVersion() mean in the InputInitializerEvent. Is it event version, attempt version? IMO until TEZ-1447 goes in, this is practically useless. So we could remove it now and add it compatibly later on with a meaningful name, impl etc.
          sseth Siddharth Seth added a comment -

          Updated patch. Also changes Descriptors, VertexLocationHint and all the Events. Removes version.
          Committing. Thanks for taking a look bikassaha

          sseth Siddharth Seth added a comment - Updated patch. Also changes Descriptors, VertexLocationHint and all the Events. Removes version. Committing. Thanks for taking a look bikassaha
          sseth Siddharth Seth added a comment -

          Committed to master.

          sseth Siddharth Seth added a comment - Committed to master.
          bikassaha Bikas Saha added a comment -

          Bulk close for jiras fixed in 0.5.0.

          bikassaha Bikas Saha added a comment - Bulk close for jiras fixed in 0.5.0.

          People

            sseth Siddharth Seth
            bikassaha Bikas Saha
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: