Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.5.0
    • None
    • None
    • Incompatible change, Reviewed

    Description

      Make it language agnostic.

      Attachments

        1. TEZ-1130.1.patch
          23 kB
          Bikas Saha
        2. TEZ-1130.2.patch
          34 kB
          Bikas Saha

        Activity

          bikassaha Bikas Saha added a comment -

          Rename javaOpts to taskLaunchOpts. Rename getVertexName() to getName().

          Added docs for methods.

          I am considering renaming setTaskLocalResources() to prevent confusion with Resource (memory). Maybe change to setTaskLocalFiles(). Files sounds much more clear as to the intent.

          hiteshssethkamrul Please review.

          Orthogonally, should Tez have its own definition of Resource and LocalResource?

          bikassaha Bikas Saha added a comment - Rename javaOpts to taskLaunchOpts. Rename getVertexName() to getName(). Added docs for methods. I am considering renaming setTaskLocalResources() to prevent confusion with Resource (memory). Maybe change to setTaskLocalFiles(). Files sounds much more clear as to the intent. hitesh sseth kamrul Please review. Orthogonally, should Tez have its own definition of Resource and LocalResource?
          hitesh Hitesh Shah added a comment -

          Looks fine. Please check javadoc warnings. Some params and return bits do not have any descriptions.

          hitesh Hitesh Shah added a comment - Looks fine. Please check javadoc warnings. Some params and return bits do not have any descriptions.
          hitesh Hitesh Shah added a comment -

          Resource and LocalResource at some point would need to be considered if Tez is deployed on non-YARN clusters. LocalResource is problematic in any case given its use of a structured protobuf-backed object for the URL.

          hitesh Hitesh Shah added a comment - Resource and LocalResource at some point would need to be considered if Tez is deployed on non-YARN clusters. LocalResource is problematic in any case given its use of a structured protobuf-backed object for the URL.
          bikassaha Bikas Saha added a comment -

          Commit patch. Thanks for the review.
          Renamed get/setTaskLocalResources() -> get/setTaskLocalFiles()

          bikassaha Bikas Saha added a comment - Commit patch. Thanks for the review. Renamed get/setTaskLocalResources() -> get/setTaskLocalFiles()
          bikassaha Bikas Saha added a comment -

          The incompatible changes in this patch are
          1) Vertex.getVertexName() -> Vertex.getName()
          2) Vertex.get/setTaskLocalResource() -> Vertex.get/setTaskLocalFiles()
          3) Vertex.get/setJavaOpts() -> Vertex.get/setTaskLaunchCmdOpts()

          bikassaha Bikas Saha added a comment - The incompatible changes in this patch are 1) Vertex.getVertexName() -> Vertex.getName() 2) Vertex.get/setTaskLocalResource() -> Vertex.get/setTaskLocalFiles() 3) Vertex.get/setJavaOpts() -> Vertex.get/setTaskLaunchCmdOpts()
          bikassaha Bikas Saha added a comment -

          commit cfe9a42a9bd08b983d60d3823d9ed47c15ebdcf2
          Author: Bikas Saha <bikas@apache.org>
          Date: Fri Jul 11 13:47:20 2014 -0700

          TEZ-1130. Replace confusing names on Vertex API (bikas)

          bikassaha Bikas Saha added a comment - commit cfe9a42a9bd08b983d60d3823d9ed47c15ebdcf2 Author: Bikas Saha <bikas@apache.org> Date: Fri Jul 11 13:47:20 2014 -0700 TEZ-1130 . Replace confusing names on Vertex API (bikas)

          tez.am.java.opts - Will this also become tez.am.cmd-opts to become consistent ?

          rohini Rohini Palaniswamy added a comment - tez.am.java.opts - Will this also become tez.am.cmd-opts to become consistent ?
          bikassaha Bikas Saha added a comment -

          Yes. We should do it.

          bikassaha Bikas Saha added a comment - Yes. We should do it.
          hitesh Hitesh Shah added a comment -

          rohini I believe bikassaha was planning to make that change in another jira but it was eventually decided not to due to it being a bit de-stabilizing to folks who are already using Tez. One option might be to temporarily introduce a deprecated config property for a version or 2.

          hitesh Hitesh Shah added a comment - rohini I believe bikassaha was planning to make that change in another jira but it was eventually decided not to due to it being a bit de-stabilizing to folks who are already using Tez. One option might be to temporarily introduce a deprecated config property for a version or 2.
          bikassaha Bikas Saha added a comment -

          given the number of changes we have made we might as well do this now.

          bikassaha Bikas Saha added a comment - given the number of changes we have made we might as well do this now.
          bikassaha Bikas Saha added a comment -

          Bulk close for jiras fixed in 0.5.0.

          bikassaha Bikas Saha added a comment - Bulk close for jiras fixed in 0.5.0.

          People

            bikassaha Bikas Saha
            bikassaha Bikas Saha
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: