[TEXT-211] TextStringBuilder equals method changed behaviour from 1.8 to 1.9

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9
• Fix Version/s: 1.10.0
• Assignee: Unassigned
• Reporter: Nikolaos Georgiou
• Created: 08/Jul/21 14:45
• Updated: 27/Apr/22 12:04
• Resolved: 31/Mar/22 14:36

Description

We found a regression (or breaking compatibility change) in the TextStringBuilder equals method when upgrading commons-text from 1.8 to 1.9

 

The 1.8 version ( https://github.com/apache/commons-text/blob/commons-text-1.8/src/main/java/org/apache/commons/text/TextStringBuilder.java#L2915 ) would only compare the parts of the buffer that fall within the range 0..size.

The 1.9 version ( https://github.com/apache/commons-text/blob/rel/commons-text-1.9/src/main/java/org/apache/commons/text/TextStringBuilder.java#L1855 ) compares the entire buffer arrays.

If a TextStringBuilder has extra capacity in the buffer, comparison fails.

 

Issue Links

• links to: GitHug Pull Request #281