[TEXT-186] StringSubstitutor map constructor throws NPE on 1.9 with null map

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.9, 1.10.0
• Fix Version/s: 1.10.0
• Assignee: Unassigned
• Reporter: Gautam Korlam
• Created: 13/Aug/20 19:05
• Updated: 14/Aug/20 07:32
• Resolved: 14/Aug/20 05:44

Description

Steps to reproduce

 

Add a test to StringSubstitutorTest

    @Test
    public void testConstructorNullMap() {
        Map<String, Object> parameters = null;
        final StringSubstitutor s = new StringSubstitutor(parameters, "prefix", "suffix");
    }

 

Test passes on 1.8. Fails on 1.9 . According to the javadoc, the map value is nullable - https://github.com/apache/commons-text/blob/master/src/main/java/org/apache/commons/text/StringSubstitutor.java#L445