[TEXT-175] WordUtils.capitalizeFully(String) only splits by spaces, instead of any whitespace

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2, 1.8
• Fix Version/s: 1.12.0
• Assignee: Unassigned
• Reporter: David Lavati
• Created: 07/Jan/20 13:16
• Updated: 31/Mar/24 10:17
• Resolved: 29/Mar/24 12:23

Description

Due to the performance improvements in TEXT-98, this no longer works as originally designed:

• org.apache.commons.text.WordUtils.capitalizeFully("a\tb\nc")
  • should return "A\t\B\nC", but returns "A\t\b\nc" instead
• org.apache.commons.text.WordUtils.capitalizeFully("a b c")
  • still works as "A B C"

 

A possible option while keeping the improvements would be to create a static collection of whitespace codepoints and

• either include that into the set, instead of just the single whitespace, as done at https://github.com/apache/commons-text/commit/fb6d5935451397c561bd52cf1d483975f83b2c7b#diff-9222b0893e00b43fd6519d95e395f9b3R892
• or if that touches too many things, call capitalize(String,char[])  inside capitalizeFully with these chars as delimiters by default.

 

Tested in 1.8

Issue Links

• links to: Github PR 519
• links to: GitHub Pull Request #127
• links to: GitHub Pull Request #519