[TEXT-151] JaroWinklerSimilarity uses Object.equals to test for equality

• Type: Bug
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.7
• Assignee: Alex Herbert
• Reporter: Alex Herbert
• Created: 02/Mar/19 20:53
• Updated: 08/Mar/19 16:29
• Resolved: 08/Mar/19 16:29

Description

Using Object.equals to test for equality of a CharSequence is wrong:

CharSequence cs1, cs2;
cs1.equals(cs2);

The Unit test passes because the test uses the same String on both sides. When I changed the unit test to wrap the string with a CharSequence interface it fails.

It should be replaced with:

CharSequence cs1, cs2;
StringUtils.equals(cs1, cs2);

Issue Links

• links to: GitHub Pull Request #105