[TEXT-149] StringEscapeUtils.unescapeCsv doesn't remove quotes at begin and end of string

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.6
• Fix Version/s: 1.9
• Assignee: Bruno P. Kinoshita
• Reporter: Krzysztof Szalast
• Created: 11/Dec/18 13:53
• Updated: 22/Sep/19 21:10
• Resolved: 22/Sep/19 21:10

Description

org.apache.commons.text.translate.CsvTranslators:

void translateWhole(CharSequence input, Writer out) throws IOException {
    if (input.charAt(0) == '"' && input.charAt(input.length() - 1) == '"') {
        String quoteless = input.subSequence(1, input.length() - 1).toString();
        if (StringUtils.containsAny(quoteless, CsvTranslators.CSV_SEARCH_CHARS)) {
            out.write(StringUtils.replace(quoteless, CsvTranslators.CSV_ESCAPED_QUOTE_STR, CsvTranslators.CSV_QUOTE_STR));
        } else {
            out.write(input.toString());
        }

    } else {
        out.write(input.toString());
    }
}

 

In my opinion first occurence "out.write(input.toString());" should be replaced with:

out.write(quoteless.toString());

Because '"' quotes around "input" will be never removed.

Issue Links

• links to: GitHub Pull Request #119