Uploaded image for project: 'Tephra'
  1. Tephra
  2. TEPHRA-231

Fix the License and the Notice Files for the binary distribution

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0-incubating
    • Fix Version/s: 0.13.0-incubating
    • Component/s: None
    • Labels:
      None

      Description

      • Includes logback which is EPL/LGPL needs to be in LICENSE as EPL
      • javax.inject should be CDDL
      • Includes jsr305 which is an LGPL binary. There is a clean room
        implementation that is more compliant
      • guice includes a NOTICE to include in the binary
      • ASM is BSD 3 clause, should be in LICENSE http://asm.ow2.org/license.html
      • Same for jline

      From http://mail-archives.apache.org/mod_mbox/incubator-general/201705.mbox/%3CCAOqetn-BFk8uHj89Rix2ozJYfuZ9FidSH7xRjEvKJ%3Dr0YbJdtA%40mail.gmail.com%3E

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-tephra/pull/58

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/58
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gokulavasan commented on the issue:

          https://github.com/apache/incubator-tephra/pull/58

          @poornachandra Thanks for the review. Addressed your comment (moved LICENSE and NOTICE files under tephra-distribution). Please take a look again.

          Show
          githubbot ASF GitHub Bot added a comment - Github user gokulavasan commented on the issue: https://github.com/apache/incubator-tephra/pull/58 @poornachandra Thanks for the review. Addressed your comment (moved LICENSE and NOTICE files under tephra-distribution). Please take a look again.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user poornachandra commented on the issue:

          https://github.com/apache/incubator-tephra/pull/58

          I did a build and was able to see the new license and notice files in the distribution jar.

          Can we rename `LICENSE_RELEASE` to `LICENSE_DISTRIBUTION` and `NOTICE_RELEASE` to `NOTICE_DISTRIBUTION`, since they only apply to the distribution tarball? Also is it okay to move them into `tephra-distribution/` directory for the same reason? In that case we can just call them `LICENSE` and `NOTICE`

          Show
          githubbot ASF GitHub Bot added a comment - Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/58 I did a build and was able to see the new license and notice files in the distribution jar. Can we rename `LICENSE_RELEASE` to `LICENSE_DISTRIBUTION` and `NOTICE_RELEASE` to `NOTICE_DISTRIBUTION`, since they only apply to the distribution tarball? Also is it okay to move them into `tephra-distribution/` directory for the same reason? In that case we can just call them `LICENSE` and `NOTICE`
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user gokulavasan opened a pull request:

          https://github.com/apache/incubator-tephra/pull/58

          TEPHRA-231 Fix LICENSE and NOTICE files for release distribution

          JIRA : https://issues.apache.org/jira/browse/TEPHRA-231

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/gokulavasan/incubator-tephra feature/tephra-231

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-tephra/pull/58.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #58


          commit 74a3dda16cb8803723785c61e41507122b8c83aa
          Author: Gokul Gunasekaran <gokul@cask.co>
          Date: 2017-09-13T07:58:24Z

          TEPHRA-231 Fix NOTICE and LICENSE files

          commit e3b5386fa6d927c27eacb9c0e828ad7a10587e2e
          Author: Gokul Gunasekaran <gokul@cask.co>
          Date: 2017-09-13T18:02:34Z

          Modify pom and assemble xml to package licenses into the tar gz file


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user gokulavasan opened a pull request: https://github.com/apache/incubator-tephra/pull/58 TEPHRA-231 Fix LICENSE and NOTICE files for release distribution JIRA : https://issues.apache.org/jira/browse/TEPHRA-231 You can merge this pull request into a Git repository by running: $ git pull https://github.com/gokulavasan/incubator-tephra feature/tephra-231 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-tephra/pull/58.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #58 commit 74a3dda16cb8803723785c61e41507122b8c83aa Author: Gokul Gunasekaran <gokul@cask.co> Date: 2017-09-13T07:58:24Z TEPHRA-231 Fix NOTICE and LICENSE files commit e3b5386fa6d927c27eacb9c0e828ad7a10587e2e Author: Gokul Gunasekaran <gokul@cask.co> Date: 2017-09-13T18:02:34Z Modify pom and assemble xml to package licenses into the tar gz file

            People

            • Assignee:
              gokulavasan Gokul Gunasekaran
              Reporter:
              gokulavasan Gokul Gunasekaran
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development