Uploaded image for project: 'Apache Taverna'
  1. Apache Taverna
  2. TAVERNA-1043

Java 9: ZIPFS folders no longer ends with /

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: language 0.15.1
    • Fix Version/s: language 0.16.0
    • Component/s: Taverna Language
    • Labels:
      None
    • Environment:
      JDK 9

      Description

      Taverna Language on JDK9 fails with:

      Failed tests: 
        TestZipFS.directoryOrFile:134
        TestManifest.populateFromBundle:93
        TestManifest.repopulateFromBundle:130
        TestManifestJSON.createBundle:206->checkManifestJson:290 expected:</folder[/]> but was:</folder[]>
      

      This seems mainly to be because this JDK7 bug has finally been fixed. We used to test this in [TestZipFS](https://github.com/apache/incubator-taverna-language/blob/0.15.1-incubating/taverna-robundle/src/test/java/org/apache/taverna/robundle/fs/TestZipFS.java#L95) - but this test now fails as the underlying ZipFS now in JDK9 finally correctly throws FileAlreadyExistsException if attempting to make folder/ after having made a file called just folder.

      But this mean some of the other code (and their tests) maintaining the manifest.json gets inconsistent folder paths with or without trailing /. We should keep the JSON serialization and RO API with / at the end for consistency.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                stain Stian Soiland-Reyes
                Reporter:
                stain Stian Soiland-Reyes
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: