Tapestry
  1. Tapestry
  2. TAPESTRY-988

Function mismatch with description in document: Form.jwc and tapestry.request.xml

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0.1
    • Fix Version/s: 4.1.2
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      hivemind1.1.1

      Description

      1/ Form component specifiaction

      <parameter name="clientValidationEnabled">
      <description>
      If true (the default) then client-side validation will be generated upon render for any
      required or validating fields.
      </description>
      </parameter>

      Shoud declare a default value as description elment said. Or else, the value of clientValidationEnabled property in enhanced Form class will be false.

      <parameter name="clientValidationEnabled" default-value="ognl:true">

      2/CookieSource hivemind configuration:

      <service-point id="CookieSource">

      Allows access to incoming HTTP cookie values for the active (per-thread) request.

      <invoke-factory>
      <construct class="impl.CookieSourceImpl">
      <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
      <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
      <set property="defaultMaxAge" value="$

      {org.apache.tapestry.default-cookie-max-age}"/>
      </construct>
      </invoke-factory>
      </service-point>


      <set property="defaultMaxAge" value="${org.apache.tapestry.default-cookie-max-age}

      "/>

      Here, defaultMaxAge value is injected by propertyname placeHolder, it will not prefer to search value from application specification meta elment - "org.apache.tapestry.default-cookie-max-age". (I test it twice.)

      But this document say that specialize meta in app spec will be useful. Or I misunderstand?

      http://jakarta.apache.org/tapestry/UsersGuide/configuration.html#configuration.properties

      I think "app-property:org.apache.tapestry.default-cookie-max-age" will be ok. Like this:

      <implementation service-id="tapestry.request.CookieSource">
      <invoke-factory>
      <construct class="framework.tapestry.service.CookieSourceImpl">
      <set-service property="request" service-id="tapestry.globals.HttpServletRequest"/>
      <set-service property="response" service-id="tapestry.globals.HttpServletResponse"/>
      <set-object property="defaultMaxAge" value="app-property:org.apache.tapestry.default-cookie-max-age"/>
      <set-object property="domain" value="app-property:framework.tapestry.default-cookie-domain"/>
      <set-object property="path" value="app-property:framework.tapestry.default-cookie-path"/>
      <set-object property="version" value="app-property:framework.tapestry.default-cookie-version"/>
      </construct>
      </invoke-factory>
      </implementation>

      But must define my own implements.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568911 ] jira [ 12591977 ]
        Mark Thomas made changes -
        Workflow jira [ 12373702 ] Default workflow, editable Closed status [ 12568911 ]
        Jesse Kuhnert made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Jesse Kuhnert [ jkuhnert ]
        Hide
        Jesse Kuhnert added a comment -

        Fixed the service configs and double checked to be sure the documentation is correct. (which it is now in 4.1.2 )

        Show
        Jesse Kuhnert added a comment - Fixed the service configs and double checked to be sure the documentation is correct. (which it is now in 4.1.2 )
        Andreas Andreou made changes -
        Assignee Andreas Andreou [ andyhot ]
        Hide
        Andreas Andreou added a comment -

        Regarding org.apache.tapestry.default-cookie-max-age, I guess it needs to be specified as a JVM system property.

        Since CookieSource allows setting per-cookie max ages, i don't feel this is important any more - but the docs should be updated.

        Show
        Andreas Andreou added a comment - Regarding org.apache.tapestry.default-cookie-max-age, I guess it needs to be specified as a JVM system property. Since CookieSource allows setting per-cookie max ages, i don't feel this is important any more - but the docs should be updated.
        Andreas Andreou made changes -
        Assignee Andreas Andreou [ andyhot ]
        Jesse Kuhnert made changes -
        Field Original Value New Value
        Fix Version/s 4.1.2 [ 12312202 ]
        sorphi created issue -

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            sorphi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development