[TAPESTRY-975] Overriding ValidationDelegate and adding a "class" attribute results in duplicate attributes

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.0.2
• Fix Version/s: 4.1.5
• Component/s: Framework
• Assignee: Jesse Kuhnert
• Reporter: Matt Raible
• Created: 02/Jun/06 05:44
• Updated: 14/Sep/07 01:07
• Resolved: 14/Sep/07 01:07

Description

I have the following in my custom ValidationDelegate:

public void writeAttributes(IMarkupWriter writer, IRequestCycle cycle,
IFormComponent component, IValidator validator) {
if (isInError())

{ String cssClass = ((component.getBinding("class") != null) ? component.getBinding("class").getObject().toString() : ""); writer.attribute("class", cssClass + " error"); }

}

However, rather than just writing a single "class" attribute, it writes two:

class="text large error" class="text large"

Ideally, only one "class" attribute gets written. Maybe IMarkupWriter nees an appendAttribute() method, or it just needs to be smart enough to detect duplicates?

Issue Links

• relates to: TAPESTRY-550 IMarkupWriter should automatically filter out duplicate attributes when rendering an element