Tapestry
  1. Tapestry
  2. TAPESTRY-2602

Error bubbles are in some cases placed incorrectly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0.14
    • Fix Version/s: 5.0.15
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      The error bubbles utilized by Tapestry's client-side validation are in some cases placed incorrectly. I suspect that this happens for me because my page layout uses lots of relative positioning.

      Changing positionedOffset in Tapestry.ErrorPopup.repositionBubble to cumulativeOffset fixes this.

        Activity

        Hide
        Filip S. Adamsen added a comment -

        Attached a patch against r686911.

        Show
        Filip S. Adamsen added a comment - Attached a patch against r686911.
        Hide
        Howard M. Lewis Ship added a comment -

        Thanks for the patch!

        I snuck in a few changes that make it easier to override Tapestry's field decorations a bit; we now render a 1x1 spacer gif and then use CSS to set the width, height and background image. This means that different CSS can use a different icon quite easily.

        Show
        Howard M. Lewis Ship added a comment - Thanks for the patch! I snuck in a few changes that make it easier to override Tapestry's field decorations a bit; we now render a 1x1 spacer gif and then use CSS to set the width, height and background image. This means that different CSS can use a different icon quite easily.
        Hide
        Filip S. Adamsen added a comment -

        Sounds good! Although with this fix I'm not eager to change the default style at all.

        Show
        Filip S. Adamsen added a comment - Sounds good! Although with this fix I'm not eager to change the default style at all.

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Filip S. Adamsen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development