Tapestry
  1. Tapestry
  2. TAPESTRY-2586

Some abstract base class methods should be overridable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.14
    • Fix Version/s: 5.0.15
    • Component/s: tapestry-core
    • Labels:
      None
    • Environment:
      All

      Description

      In TAPESTRY-2484 TextField, PasswordField, TextArea classes were made extensible. However the abstract classes with all the really interesting stuff are still marked final. In AbstractTextField methods final void begin(MarkupWriter writer) and protected final void processSubmission(String elementName) are still final.

      Could these be made extensible also?

      Now if I want to have my own validator and translator logic / sources I have to copy the abstract field code to my codebase and make changes.

        Activity

        Ville Virtanen created issue -
        Igor Drobiazko made changes -
        Field Original Value New Value
        Assignee Igor Drobiazko [ igor.drobiazko ]
        Igor Drobiazko made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Mark Thomas made changes -
        Workflow jira [ 12437393 ] Default workflow, editable Closed status [ 12569351 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12569351 ] jira [ 12592155 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        21d 12h 26m 1 Igor Drobiazko 04/Sep/08 21:54

          People

          • Assignee:
            Igor Drobiazko
            Reporter:
            Ville Virtanen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development