Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.1, 4.0.2
    • Fix Version/s: 4.1.1
    • Component/s: Framework
    • Labels:
      None

      Description

      It would be handy if the Shell component supported setting a favicon.

      eg. same as how the stylesheet can be filled in from the Shell component -

      <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />

      I'd expect to be able to have

      <private-asset name="favicon" resource-path="/images/favicon.ico"/>

      and then

      <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">

      If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12566975 ] jira [ 12589732 ]
        Mark Thomas made changes -
        Workflow jira [ 39784 ] Default workflow, editable Closed status [ 12566975 ]
        Andreas Andreou made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 3.0.5 [ 12310940 ]
        Status In Progress [ 3 ] Resolved [ 5 ]
        Hide
        Andreas Andreou added a comment -

        Changes in TAPESTRY-199 fixed this.
        Using <link jwcid="@Relation" href="assetOrString" rel="shortcut icon" />
        from anywhere in a page or component, results in the favicon being added
        in <HEAD> of the page

        Show
        Andreas Andreou added a comment - Changes in TAPESTRY-199 fixed this. Using <link jwcid="@Relation" href="assetOrString" rel="shortcut icon" /> from anywhere in a page or component, results in the favicon being added in <HEAD> of the page
        Andreas Andreou made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Andreas Andreou made changes -
        Assignee Brian K. Wallace [ vaporrun ] Andreas Andreou [ andyhot ]
        Jesse Kuhnert made changes -
        Fix Version/s 4.1 [ 12310632 ]
        Fix Version/s 4.1.1 [ 12312021 ]
        Jesse Kuhnert made changes -
        Fix Version/s 4.0.3 [ 12310994 ]
        Fix Version/s 4.1 [ 12310632 ]
        Hide
        Andreas Andreou added a comment -

        Of course, this could render
        <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" /> (as stated)
        but i've seen (for instance in this very site)
        <link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> (type is missing)
        and also
        <link rel="icon" type="image/png" href="/jira/images/icons/favicon.png"> (different type and rel)

        Given those alternatives, perhaps we can take care of this in a more generic way.

        Perhaps the favicon parameter should only generate:
        <link rel="shortcut icon" href="/jira/images/icons/favicon.ico">
        and we can have an additional parameter 'links' which will accept a List or Collection or array of a
        new class, named Link or HtmlLink or HtmlRelation. This should have href, media, name, rev, rel, title, type
        properties and will be able to render them if they contain a non-null value.
        See http://www.blooberry.com/indexdot/html/tagpages/l/link.htm for more, but i think these are the most important
        and they do cover css inclusion in a much better way than the currently supported.

        Returning to the favicon issue, I also believe that the favicon parameter (ot whatever its name will be) should be an IAsset but also a simple string.

        Show
        Andreas Andreou added a comment - Of course, this could render <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" /> (as stated) but i've seen (for instance in this very site) <link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> (type is missing) and also <link rel="icon" type="image/png" href="/jira/images/icons/favicon.png"> (different type and rel) Given those alternatives, perhaps we can take care of this in a more generic way. Perhaps the favicon parameter should only generate: <link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> and we can have an additional parameter 'links' which will accept a List or Collection or array of a new class, named Link or HtmlLink or HtmlRelation. This should have href, media, name, rev, rel, title, type properties and will be able to render them if they contain a non-null value. See http://www.blooberry.com/indexdot/html/tagpages/l/link.htm for more, but i think these are the most important and they do cover css inclusion in a much better way than the currently supported. Returning to the favicon issue, I also believe that the favicon parameter (ot whatever its name will be) should be an IAsset but also a simple string.
        Brian K. Wallace made changes -
        Assignee Brian K. Wallace [ vaporrun ]
        Andreas Andreou made changes -
        Field Original Value New Value
        Affects Version/s 4.0.2 [ 12310870 ]
        Fix Version/s 3.0.5 [ 12310940 ]
        Fix Version/s 4.0.3 [ 12310994 ]
        Ben Walding created issue -

          People

          • Assignee:
            Andreas Andreou
            Reporter:
            Ben Walding
          • Votes:
            5 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development