Tapestry
  1. Tapestry
  2. TAPESTRY-2522

RequestPathOptimizer will corrupt query parameters in the optimized URL if the parameters container slashes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.13
    • Fix Version/s: 5.0.14
    • Component/s: None
    • Labels:
      None

      Description

      The RequestPathOptimizer removes repetitions of the slash-character from the url, including the parameters and therefore the client-state. If the base64-encoded client state contains data that encodes i.e. to 'Hasc//asc==' the optimizer changes the url from
      /context/start?t:state:client=Hasc//asc==
      to
      /context/start?t:state:client=Hasc/asc==
      which leads to deserialization errors.

      1. optimize-bug-testcase.patch
        2 kB
        Mario Siegenthaler
      2. optimize-bug-fix.patch
        2 kB
        Mario Siegenthaler

        Activity

        Mario Siegenthaler created issue -
        Hide
        Mario Siegenthaler added a comment -

        Extension to the RequestPathOptimizerImplTest showing the problem.

        Show
        Mario Siegenthaler added a comment - Extension to the RequestPathOptimizerImplTest showing the problem.
        Mario Siegenthaler made changes -
        Field Original Value New Value
        Attachment optimize-bug-testcase.patch [ 12386175 ]
        Mario Siegenthaler made changes -
        Attachment optimize-bug-testcase.patch [ 12386175 ]
        Hide
        Mario Siegenthaler added a comment -

        Fixed the context-path in the testcase

        Show
        Mario Siegenthaler added a comment - Fixed the context-path in the testcase
        Mario Siegenthaler made changes -
        Attachment optimize-bug-testcase.patch [ 12386176 ]
        Hide
        Mario Siegenthaler added a comment -

        Proposed fix for this issue.

        Show
        Mario Siegenthaler added a comment - Proposed fix for this issue.
        Mario Siegenthaler made changes -
        Attachment optimize-bug-fix.patch [ 12386177 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Summary RequestPathOptimizer destroys client-state RequestPathOptimizer will corrupt query parameters in the optimized URL if the parameters container slashes
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.14 [ 12313214 ]
        Mark Thomas made changes -
        Workflow jira [ 12435408 ] Default workflow, editable Closed status [ 12568761 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568761 ] jira [ 12591780 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        12d 9h 2m 1 Howard M. Lewis Ship 28/Jul/08 22:34
        In Progress In Progress Closed Closed
        12m 6s 1 Howard M. Lewis Ship 28/Jul/08 22:46

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Mario Siegenthaler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 0.25h
              0.25h
              Remaining:
              Remaining Estimate - 0.25h
              0.25h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development