Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.0.14
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      patch added

      1. tapestry-core_language_de.patch
        9 kB
        Sven Homburg
      2. german-utf8.patch
        4 kB
        Sven Homburg
      3. german-utf8-II.patch
        4 kB
        Sven Homburg
      4. german-utf8-3.patch
        15 kB
        Christian Köberl
      5. TAPESTRY-2443.txt
        18 kB
        Ulrich Stärk

        Issue Links

          Activity

          Hide
          Sven Homburg added a comment -

          sorry,

          the first patch contains NOT the UTF chars for german special letter like u-umlaut.
          in the second patch i contvert it to UTF-8

          Show
          Sven Homburg added a comment - sorry, the first patch contains NOT the UTF chars for german special letter like u-umlaut. in the second patch i contvert it to UTF-8
          Hide
          Christian Köberl added a comment -

          @Sven: there is still a problem with the German texts. You've changed the position of %d and %s in the "minimum-string-length" and "maximum-string-length". Could you please fix this with:

          minimum-string-length=Der Wert für das Feld %2$s muss mindestens %1$d Zeichen lang sein.
          maximum-string-length=Der Wert für das Feld %2$s darf maximal %1$d Zeichen lang sein.

          Show
          Christian Köberl added a comment - @Sven: there is still a problem with the German texts. You've changed the position of %d and %s in the "minimum-string-length" and "maximum-string-length". Could you please fix this with: minimum-string-length=Der Wert für das Feld %2$s muss mindestens %1$d Zeichen lang sein. maximum-string-length=Der Wert für das Feld %2$s darf maximal %1$d Zeichen lang sein.
          Hide
          Christian Köberl added a comment -

          @Howard:
          could you please rename the files just "_de" (not "_de_DE"). The texts apply to all German languages (at least "_de_AT").

          PS: yes, I'm from Austria

          Show
          Christian Köberl added a comment - @Howard: could you please rename the files just "_de" (not "_de_DE"). The texts apply to all German languages (at least "_de_AT"). PS: yes, I'm from Austria
          Hide
          Sven Homburg added a comment -

          ve changed the two strings
          now they sounds a bit strange but the sense is discernible

          Show
          Sven Homburg added a comment - ve changed the two strings now they sounds a bit strange but the sense is discernible
          Hide
          Sven Homburg added a comment -

          @Christian

          please think over once more, some people wants to read the messages
          translated into "wiener schmaeh"

          (just kidding)

          Show
          Sven Homburg added a comment - @Christian please think over once more, some people wants to read the messages translated into "wiener schmaeh" (just kidding)
          Hide
          Christian Köberl added a comment - - edited

          @Sven: I thought you would use the syntax with "%2$s". Your changes to the German texts don't read German anymore (at least for an Austrian )

          This patch (german-utf8-3.patch) fixes both issues.

          1. it deletes the _de_DE files and copies the content in _de files
          2. it fixes the texts with "%2$s" syntax and keeps German grammar intact

          @Sven
          please check this again

          Cheers,
          Chris

          Show
          Christian Köberl added a comment - - edited @Sven: I thought you would use the syntax with "%2$s". Your changes to the German texts don't read German anymore (at least for an Austrian ) This patch (german-utf8-3.patch) fixes both issues. 1. it deletes the _de_DE files and copies the content in _de files 2. it fixes the texts with "%2$s" syntax and keeps German grammar intact @Sven please check this again Cheers, Chris
          Hide
          Ulrich Stärk added a comment -

          This is a huge mess. Sorry if this sounds rude but it simply is.

          There are language inaccuracies:

          • man berichtigt (amend) einen Text oder eine Person aber man behebt (correct) einen Fehler
          • ein Datensatz wird angelegt (create), nicht erstellt (build)
          • it is "die folgenden Fehler" or "folgende Fehler" but definitely not "die folgende Fehler"
          • go to = "gehe zu" not "wähle"
          • integer value = "ganzzahliger Wert" and not "Zahlenwert"
          • others...

          There are keys missing:

          • invalid-email
          • integer-format-exception
          • number-format-exception

          and you mixed up UTF-8 encoding and unicode escaped characters. Use either but not both.
          The patch I created addresses all these issues. Howard, please include it as soon as you can.

          Uli

          Show
          Ulrich Stärk added a comment - This is a huge mess. Sorry if this sounds rude but it simply is. There are language inaccuracies: man berichtigt (amend) einen Text oder eine Person aber man behebt (correct) einen Fehler ein Datensatz wird angelegt (create), nicht erstellt (build) it is "die folgenden Fehler" or "folgende Fehler" but definitely not "die folgende Fehler" go to = "gehe zu" not "wähle" integer value = "ganzzahliger Wert" and not "Zahlenwert" others... There are keys missing: invalid-email integer-format-exception number-format-exception and you mixed up UTF-8 encoding and unicode escaped characters. Use either but not both. The patch I created addresses all these issues. Howard, please include it as soon as you can. Uli
          Hide
          Howard M. Lewis Ship added a comment -

          Ah this is fixed in 5.0.14. I'm going to create a new issue for the changes in 5.0.15.

          Show
          Howard M. Lewis Ship added a comment - Ah this is fixed in 5.0.14. I'm going to create a new issue for the changes in 5.0.15.

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Sven Homburg
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development