Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.1
    • Component/s: Contrib, Framework
    • Labels:
      None

      Description

      I think the Tapestry components should generate valid XHTML 1.0 Strict. Components that generate XHTML can still be used to build HTML 4.01 pages, so XHTML 1.0 Strict seems to be the best choice.

      Currently there are the following XHTML issues with Tapestry:

      *) some tag attributes are not quoted properly. For example <td
      colspan=2> instead of <td colspan="2">.

      *) some attributes are no longer supported in XHTML 1.0 Strict. For
      example the img tag no longer has a border attribute. This
      affects the border parameter of the Image component as well. People who
      create HTML 4.01 pages can easily remove the border using Cascading Style Sheets.

      *) some tag attributes have changed. For example <script language=...> has
      been replaced by <script type=...>

      1. xhtml-1.patch
        6 kB
        Markus Wiederkehr

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        261d 9h 55m 1 Howard M. Lewis Ship 09/Sep/05 22:06
        Closed Closed Reopened Reopened
        242d 5h 41m 1 Jesse Kuhnert 10/May/06 03:48
        Reopened Reopened Resolved Resolved
        75d 15h 40m 1 Jesse Kuhnert 24/Jul/06 19:28
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568986 ] jira [ 12590275 ]
        Mark Thomas made changes -
        Workflow jira [ 39121 ] Default workflow, editable Closed status [ 12568986 ]
        Jesse Kuhnert made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Jesse Kuhnert added a comment -

        Removed form name attribute being written. Let us know if anything else comes up.

        Show
        Jesse Kuhnert added a comment - Removed form name attribute being written. Let us know if anything else comes up.
        Brian K. Wallace made changes -
        Fix Version/s 4.0 [ 10794 ]
        Fix Version/s 4.1 [ 12310632 ]
        Jesse Kuhnert made changes -
        Status Closed [ 6 ] Reopened [ 4 ]
        Assignee Howard M. Lewis Ship [ hlship ] Jesse Kuhnert [ jkuhnert ]
        Resolution Fixed [ 1 ]
        Hide
        Jesse Kuhnert added a comment -

        Ensure and test that XHTML support really is present throughout the framework.

        Show
        Jesse Kuhnert added a comment - Ensure and test that XHTML support really is present throughout the framework.
        Hide
        Robert Hannebauer added a comment -

        The Form component generates an attribute "name" but the xhtml validator complains about an unknown attribute.

        Error Line 53 column 53: there is no attribute "name".
        <form method="post" action="/test/app" name="Form" id="Form">

        Show
        Robert Hannebauer added a comment - The Form component generates an attribute "name" but the xhtml validator complains about an unknown attribute. Error Line 53 column 53: there is no attribute "name". <form method="post" action="/test/app" name="Form" id="Form">
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 4.0 [ 10794 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Hide
        Howard M. Lewis Ship added a comment -

        Also, change FormSupportImpl to write out the hidden fields inside a <div>.

        Show
        Howard M. Lewis Ship added a comment - Also, change FormSupportImpl to write out the hidden fields inside a <div>.
        Hide
        Howard M. Lewis Ship added a comment -

        I'm trying to hit a few other likely problems.

        Changing Image and Rollover to not output a "border" attribute (except as an informal).

        Changeing Border to not output a "language" attribute for <script>.

        Fixing the bad templates that did not quote some attributes.

        Show
        Howard M. Lewis Ship added a comment - I'm trying to hit a few other likely problems. Changing Image and Rollover to not output a "border" attribute (except as an informal). Changeing Border to not output a "language" attribute for <script>. Fixing the bad templates that did not quote some attributes.
        Markus Wiederkehr made changes -
        Field Original Value New Value
        Attachment xhtml-1.patch [ 18453 ]
        Hide
        Markus Wiederkehr added a comment -

        This patch adds double quotes to tag attributes where necessary. It also replaces an occurance of valign=center by valign="middle".

        Show
        Markus Wiederkehr added a comment - This patch adds double quotes to tag attributes where necessary. It also replaces an occurance of valign=center by valign="middle".
        Markus Wiederkehr created issue -

          People

          • Assignee:
            Jesse Kuhnert
            Reporter:
            Markus Wiederkehr
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development