Tapestry
  1. Tapestry
  2. TAPESTRY-2398

ClassTransformation.addInjectedField() adds fields as protected which can cause exceptions due to visibility

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 5.0.12
    • Fix Version/s: 5.0.12
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      I think it is an order-of-operations problem. In some cases, a field is injected (as protected) before the check for protected fields. Needs more investigation.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568690 ] jira [ 12591718 ]
        Mark Thomas made changes -
        Workflow jira [ 12430120 ] Default workflow, editable Closed status [ 12568690 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Howard M. Lewis Ship made changes -
        Affects Version/s 5.0.12 [ 12313048 ]
        Fix Version/s 5.0.12 [ 12313048 ]
        Affects Version/s 5.0.11 [ 12312968 ]
        Hide
        Howard M. Lewis Ship added a comment -

        This has unravelled a bunch of other minor problems with component method advice.

        Show
        Howard M. Lewis Ship added a comment - This has unravelled a bunch of other minor problems with component method advice.
        Hide
        Howard M. Lewis Ship added a comment -

        The injected field was not being added as a new field, and the call to verifyFields() (inside finish()) was picking it up as a failure.

        Show
        Howard M. Lewis Ship added a comment - The injected field was not being added as a new field, and the call to verifyFields() (inside finish()) was picking it up as a failure.
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development