[TAPESTRY-2310] LabeledPropertySelectionModel.isDisabled always disables its first option

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 4.1.5
• Fix Version/s: 4.1.6
• Component/s: Core Components
• Assignee: Andreas Andreou
• Reporter: Albert Tumanov
• Created: 28/Mar/08 10:19
• Updated: 28/Mar/08 23:26
• Resolved: 28/Mar/08 23:26

Description

Maybe I understand LabeledPropertySelectionModel incorrectly,
but in 4.1.3 I could choose the "default" option, and since 4.1.5 I cannot anymore.
The model I use is like this:

public static final IPropertySelectionModel MY_MODEL = new LabeledPropertySelectionModel(
new StringPropertySelectionModel(new String[]

{ "first", "second", "third" }

));

The reason is change in revision 592802:
http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LabeledPropertySelectionModel.java?r1=515387&r2=592802&diff_format=h

It makes option #0 ALWAYS disabled.
This just isn't fare

I propose to make it configurable:

public class LabeledPropertySelectionModel implements IPropertySelectionModel
{
...
private boolean _disableDefaultLabel;
...
public LabeledPropertySelectionModel(IPropertySelectionModel model, String label, Object option, String value, boolean disableDefaulLabel)

{ this(model, label, option, value); _disableDefaultLabel = disableDefaulLabel; }

...
public boolean isDisabled(int index)

{ return index == 0 ? _disableDefaultLabel : _model.isDisabled(index - 1); }

...