Tapestry
  1. Tapestry
  2. TAPESTRY-2310

LabeledPropertySelectionModel.isDisabled always disables its first option

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 4.1.5
    • Fix Version/s: 4.1.6
    • Component/s: Core Components
    • Labels:
      None

      Description

      Maybe I understand LabeledPropertySelectionModel incorrectly,
      but in 4.1.3 I could choose the "default" option, and since 4.1.5 I cannot anymore.
      The model I use is like this:

      public static final IPropertySelectionModel MY_MODEL = new LabeledPropertySelectionModel(
      new StringPropertySelectionModel(new String[]

      { "first", "second", "third" }

      ));

      The reason is change in revision 592802:
      http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LabeledPropertySelectionModel.java?r1=515387&r2=592802&diff_format=h

      It makes option #0 ALWAYS disabled.
      This just isn't fare

      I propose to make it configurable:

      public class LabeledPropertySelectionModel implements IPropertySelectionModel
      {
      ...
      private boolean _disableDefaultLabel;
      ...
      public LabeledPropertySelectionModel(IPropertySelectionModel model, String label, Object option, String value, boolean disableDefaulLabel)

      { this(model, label, option, value); _disableDefaultLabel = disableDefaulLabel; }

      ...
      public boolean isDisabled(int index)

      { return index == 0 ? _disableDefaultLabel : _model.isDisabled(index - 1); }

      ...

        Activity

        Albert Tumanov created issue -
        Andreas Andreou made changes -
        Field Original Value New Value
        Assignee Andreas Andreou [ andyhot ]
        Andreas Andreou made changes -
        Summary LabeledPropertySelectionModel.isDisabled always disables the default option LabeledPropertySelectionModel.isDisabled always disables its first option
        Andreas Andreou made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 4.1.6 [ 12312957 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Mark Thomas made changes -
        Workflow jira [ 12427580 ] Default workflow, editable Closed status [ 12568679 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568679 ] jira [ 12590106 ]

          People

          • Assignee:
            Andreas Andreou
            Reporter:
            Albert Tumanov
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development