Tapestry
  1. Tapestry
  2. TAPESTRY-2277

Removing Label body should be parameterizable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.11
    • Fix Version/s: 5.0.15
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      think that was not a good idea for the (html)-designer purpose.
      let me know if im think wrong, but nearly every designer is working
      with WYSIWYG tools and insert the label text between the label tag.

      it s realy hard to explain the designer:
      "dont forget to remove your label value after you finish your work"

      i think its more felxible, if we can parameterize this behavior.

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open In Progress In Progress
          173d 23h 18m 1 Howard M. Lewis Ship 08/Sep/08 19:06
          In Progress In Progress Closed Closed
          15m 4s 1 Howard M. Lewis Ship 08/Sep/08 19:21
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12568606 ] jira [ 12591641 ]
          Mark Thomas made changes -
          Workflow jira [ 12426817 ] Default workflow, editable Closed status [ 12568606 ]
          Howard M. Lewis Ship made changes -
          Status In Progress [ 3 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Fix Version/s 5.0.15 [ 12313350 ]
          Fix Version/s 5.1 [ 12312964 ]
          Howard M. Lewis Ship made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Howard M. Lewis Ship made changes -
          Assignee Howard M. Lewis Ship [ hlship ]
          Hide
          Kevin C. Dorff added a comment -

          I think the goal of Tapestry is to serve BOTH the Graphic Designer AND the Java Developer and I don't see a need to compromise in this case.

          Tapestry has, to my understanding, had a long history of enabling you to write HTML (templates) that could be viewed and edited in a tool like Dreamweaver. Writing

          <t:label for="username"/>

          so where you want the label to appear is far less preferable to

          <t:label for="username">Username</t:label>

          So when I view the template, I have a good idea what is going on. I would certainly vote for an option that allows both camps to be happy with the "ignorebody" flag, or something along those lines, BUT, IMO, for the path to easiest to understand, make it default to displaying the correct label when you have a body (ignorebody defaults to true). It really threw me for a loop in 5.0.11 (my first 5.0 version) when I had the version with a body and it always displayed the body (until I removed the body). I figured it was a big until I found this "Issue".

          Show
          Kevin C. Dorff added a comment - I think the goal of Tapestry is to serve BOTH the Graphic Designer AND the Java Developer and I don't see a need to compromise in this case. Tapestry has, to my understanding, had a long history of enabling you to write HTML (templates) that could be viewed and edited in a tool like Dreamweaver. Writing <t:label for="username"/> so where you want the label to appear is far less preferable to <t:label for="username">Username</t:label> So when I view the template, I have a good idea what is going on. I would certainly vote for an option that allows both camps to be happy with the "ignorebody" flag, or something along those lines, BUT, IMO, for the path to easiest to understand, make it default to displaying the correct label when you have a body (ignorebody defaults to true). It really threw me for a loop in 5.0.11 (my first 5.0 version) when I had the version with a body and it always displayed the body (until I removed the body). I figured it was a big until I found this "Issue".
          Howard M. Lewis Ship made changes -
          Fix Version/s 5.1 [ 12312964 ]
          Fix Version/s 5.0.12 [ 12313048 ]
          Hide
          Howard M. Lewis Ship added a comment -

          It is a question: who is Tapestry supposed to serve? The graphic designer or the Java developer? I lean toward the latter.

          I think the implementation of this would be to have an ignorebody parameter.

          Show
          Howard M. Lewis Ship added a comment - It is a question: who is Tapestry supposed to serve? The graphic designer or the Java developer? I lean toward the latter. I think the implementation of this would be to have an ignorebody parameter.
          Sven Homburg made changes -
          Field Original Value New Value
          Link This issue is related to TAPESTRY-1642 [ TAPESTRY-1642 ]
          Sven Homburg created issue -

            People

            • Assignee:
              Howard M. Lewis Ship
              Reporter:
              Sven Homburg
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development