Uploaded image for project: 'Tapestry'
  1. Tapestry
  2. TAPESTRY-2256

Provide an annotation to support automatic committing of the transaction after a component or service method invocation

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.11
    • Fix Version/s: 5.0.12
    • Component/s: tapestry-hibernate
    • Labels:
      None

      Description

      It would be nice to have an annotation, @CommitAfter, that could be placed on a service interface method.

      A decorator could recognize methods with such annotations, and use the HibernateSessionManager to commit the transaction after invoking the method.

      Currently, you must inject the HSM directly and invoke commit() on it.

      1. TAPESTRY-2256.patch
        14 kB
        Igor Drobiazko

        Activity

        Hide
        igor.drobiazko Igor Drobiazko added a comment -

        Patch fixing the issue

        Show
        igor.drobiazko Igor Drobiazko added a comment - Patch fixing the issue
        Hide
        hlship Howard M. Lewis Ship added a comment -

        Good start with the patch.

        I'm looking to expand it to support @CommitAfter on component event methods as well.

        Show
        hlship Howard M. Lewis Ship added a comment - Good start with the patch. I'm looking to expand it to support @CommitAfter on component event methods as well.
        Hide
        hlship Howard M. Lewis Ship added a comment -

        Thanks for the patch; I extended it a lot, with docs, more tests, the exception logic and the ability to use the annotation on component methods. Fun stuff!

        Show
        hlship Howard M. Lewis Ship added a comment - Thanks for the patch; I extended it a lot, with docs, more tests, the exception logic and the ability to use the annotation on component methods. Fun stuff!
        Hide
        igor.drobiazko Igor Drobiazko added a comment -

        Great! I'm glad you found it helpful.

        Show
        igor.drobiazko Igor Drobiazko added a comment - Great! I'm glad you found it helpful.

          People

          • Assignee:
            hlship Howard M. Lewis Ship
            Reporter:
            hlship Howard M. Lewis Ship
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development