Tapestry
  1. Tapestry
  2. TAPESTRY-2247

Transactions should roll back, not commit, at the end of each request

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.10
    • Fix Version/s: 5.0.12
    • Component/s: tapestry-hibernate
    • Labels:
      None

      Description

      On thread cleanup, the Session should be flushed not committed. If people want to commit changes they should explicitly do so but having the transaction committed automatically can lead to some very mysterious changing of the data. In my experience, having the transaction committed automatically does more harm than good.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568640 ] jira [ 12591672 ]
        Mark Thomas made changes -
        Workflow jira [ 12425608 ] Default workflow, editable Closed status [ 12568640 ]
        Howard M. Lewis Ship made changes -
        Issue Type Task [ 3 ] Bug [ 1 ]
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.12 [ 12313048 ]
        Howard M. Lewis Ship made changes -
        Issue Type Bug [ 1 ] Task [ 3 ]
        Summary Don't commit the transaction automatically at the end of the request Transactions should roll back, not commit, at the end of each request
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Assignee Dan Adams [ hagios17 ] Howard M. Lewis Ship [ hlship ]
        Dan Adams made changes -
        Field Original Value New Value
        Assignee Dan Adams [ hagios17 ]
        Dan Adams created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Dan Adams
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development