Tapestry
  1. Tapestry
  2. TAPESTRY-2236

Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.0.15
    • Component/s: None
    • Labels:
      None
    • Environment:
      Tapestry 5.0.11-SNAPSHOT

      Description

      Hi,

      our convention is to use an _ suffix for fields, rather than a prefix. Tapestry cannot naturally transform these field names where needed. Could you please change

      org.apache.tapestry.ioc.internal.util.InternalUtils.stripMemberPrefix(String memberName)

      to strip an _ suffix as well. The following addition should do the job

      while (builder.length>0)

      { char ch = builder.charAt(builder.length-1); if (InternalUtils.NAME_PREFIX.indexOf(ch) < 0) break; builder.deleteCharAt(builder.length-1); }

      Cheers,

      Adriaan

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568622 ] jira [ 12591656 ]
        Mark Thomas made changes -
        Workflow jira [ 12425136 ] Default workflow, editable Closed status [ 12568622 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.15 [ 12313350 ]
        Status In Progress [ 3 ] Closed [ 6 ]
        Howard M. Lewis Ship made changes -
        Summary Strip of _ suffix in class transformation Strip trailing punctuation (_ and $) from member names, as is done with leading punctuation
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Howard M. Lewis Ship added a comment -

        I would have worked on this one earilier if you had set the affects version field.

        Show
        Howard M. Lewis Ship added a comment - I would have worked on this one earilier if you had set the affects version field.
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Affects Version/s 5.0 [ 12312018 ]
        Adriaan Joubert created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Adriaan Joubert
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development