Tapestry
  1. Tapestry
  2. TAPESTRY-1969

Error messages in Errors component are misaligned in Internet Explorer 7

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 5.0.7
    • Fix Version/s: 5.0.10
    • Component/s: Core Components
    • Labels:
      None
    • Environment:
      Internet Explorer 7

      Description

      Error messages are misaligned in the Errors component in Internet Explorer 7.

      I checked the CSS and found this in default.css, line 23-25:

      div.t-error li {
      margin-left:-20px;
      }

      Not sure why that needs to be there, it's definitely what's causing trouble.

      If it's there to make the list item not be indented that much, I believe "list-style-position: inside;" should be used for the list inside the box instead.

        Activity

        Hide
        Chris Lewis added a comment -

        This hack may have been to fix list item indentions, which may be better addressed by something like:

        div.t-error li

        { padding: 0px; }

        I don't personally think should T5 include an alternate stylesheet (via conditional comments, etc) automatically, but developers need to consider how to handle the realities of different rendering engines and should be aware of default T5 styles (to be aware of potential issues).

        Show
        Chris Lewis added a comment - This hack may have been to fix list item indentions, which may be better addressed by something like: div.t-error li { padding: 0px; } I don't personally think should T5 include an alternate stylesheet (via conditional comments, etc) automatically, but developers need to consider how to handle the realities of different rendering engines and should be aware of default T5 styles (to be aware of potential issues).
        Hide
        Howard M. Lewis Ship added a comment -

        Tested in Firefox, IE 6 and IE 7

        Show
        Howard M. Lewis Ship added a comment - Tested in Firefox, IE 6 and IE 7

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Filip S. Adamsen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development