Tapestry
  1. Tapestry
  2. TAPESTRY-1957

EnumValueEncoder missing null check when converting to client value

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 5.0.6
    • Fix Version/s: 5.0.8
    • Component/s: Framework
    • Labels:
      None

      Description

      Sometimes a SelectModel has a disabled "select an option..."-option (or just a breaking line) which is mapped to null.
      When this is used with the EnumValueEncoder, toClient(E value) throws a NPE.
      A simple null check solves this problem. (see patch)

        Activity

        Hide
        Howard M. Lewis Ship added a comment -

        We don't define a fix version until a fix is committed.

        Show
        Howard M. Lewis Ship added a comment - We don't define a fix version until a fix is committed.
        Hide
        Ted Steen added a comment -

        If the value encoder is going away, then at least this applies for the future EnumTranslator...

        Show
        Ted Steen added a comment - If the value encoder is going away, then at least this applies for the future EnumTranslator...
        Hide
        Ted Steen added a comment -

        patch that solves the issue

        Show
        Ted Steen added a comment - patch that solves the issue

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Ted Steen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development