Tapestry
  1. Tapestry
  2. TAPESTRY-1796

Not all writeCookieValue functions honor the tapestry.default-cookie-max-age symbol

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.14
    • Fix Version/s: 5.0.15
    • Component/s: Core Components
    • Labels:
      None

      Description

      In org.apache.tapestry.internal.services.CookiesImpl, the functions

      public void writeCookieValue(String name, String value, String path)
      public void writeDomainCookieValue(String name, String value, String domain)
      public void writeCookieValue(String name, String value, String path, String domain)

      all need the line

      cookie.setMaxAge(_defaultMaxAge);

      ...otherwise, they just set transient cookies, which doesn't appear to be the intended behavior, and is certainly not consistant behavior.

        Activity

        Ned Jackson Lovely created issue -
        Ned Jackson Lovely made changes -
        Field Original Value New Value
        Priority Minor [ 4 ] Major [ 3 ]
        Ned Jackson Lovely made changes -
        Affects Version/s 5.0.14 [ 12313214 ]
        Affects Version/s 5.0.6 [ 12312544 ]
        Howard M. Lewis Ship made changes -
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Howard M. Lewis Ship made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Fix Version/s 5.0.15 [ 12313350 ]
        Mark Thomas made changes -
        Workflow jira [ 12414077 ] Default workflow, editable Closed status [ 12568749 ]
        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568749 ] jira [ 12591771 ]

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Ned Jackson Lovely
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development