Tapestry
  1. Tapestry
  2. TAPESTRY-1753

Client-side validation is broken for PropertySelection

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 4.1.3
    • Fix Version/s: 4.1.5
    • Component/s: Core Components
    • Labels:
      None

      Description

      Matt Raible found this problem with the 4.1.3-SNAPSHOT release and reported it on the mailing list, but I didn't see a JIRA issue for it: http://www.nabble.com/Re%3A-Validation-and-CSS-with-4.1.3-SNAPSHOT-p12397222.html. The behavior is still there in this build.

      The client-side validation code produces an empty popup when you submit a form if the form contains a PropertySelection component with validators. Here's the example from Matt's message:

      <component id="countryField" type="PropertySelection">
      <binding name="model" value="countries"/>
      <binding name="value" value="user.address.country"/>
      <binding name="validators" value="validators:required"/>
      <binding name="displayName" value="message:user.address.country"/>
      </component>

      You get the blank popup even when the validation should pass (i.e., the field has a selected option). As a test I created an alternate required validator that decorates the markup but doesn't generate any validation on the client, and that one doesn't exhibit this behavior. The problem appears to lie either in changes to Dojo's "required" validation in this release or in how Tapestry is using it.

      Matt questioned whether Dojo client-side validation works with this component. It has worked in previous versions.

        Issue Links

          Activity

          James Gates created issue -
          James Gates made changes -
          Field Original Value New Value
          Description Matt Raible found this problem with the 4.1.3-SNAPSHOT release and reported it on the mailing list, but I didn't see a JIRA issue for it: http://www.nabble.com/Re%3A-Validation-and-CSS-with-4.1.3-SNAPSHOT-p12397222.html. The behavior is still there in this build.

          The client-side validation code produces an empty popup when you submit a form if the form contains a PropertySelection component with validators. Here's the example from Matt's message:

              <component id="countryField" type="PropertySelection">
                  <binding name="model" value="countries"/>
                  <binding name="value" value="user.address.country"/>
                  <binding name="validators" value="validators:required"/>
                  <binding name="displayName" value="message:user.address.country"/>
              </component>

          You get the blank popup appears even when the validation should pass (i.e., the field has a selected option). As a test I created an alternative required validator that decorates the markup but doesn't generate any validation on the client, and that one doesn't exhibit this behavior. The problem appears to lie either in changes to Dojo's "required" validation in this release or in how Tapestry is using it.

          Matt questioned whether Dojo client-side validation works with this component. It has work in previous versions.
          Matt Raible found this problem with the 4.1.3-SNAPSHOT release and reported it on the mailing list, but I didn't see a JIRA issue for it: http://www.nabble.com/Re%3A-Validation-and-CSS-with-4.1.3-SNAPSHOT-p12397222.html. The behavior is still there in this build.

          The client-side validation code produces an empty popup when you submit a form if the form contains a PropertySelection component with validators. Here's the example from Matt's message:

              <component id="countryField" type="PropertySelection">
                  <binding name="model" value="countries"/>
                  <binding name="value" value="user.address.country"/>
                  <binding name="validators" value="validators:required"/>
                  <binding name="displayName" value="message:user.address.country"/>
              </component>

          You get the blank popup appears even when the validation should pass (i.e., the field has a selected option). As a test I created an alternative required validator that decorates the markup but doesn't generate any validation on the client, and that one doesn't exhibit this behavior. The problem appears to lie either in changes to Dojo's "required" validation in this release or in how Tapestry is using it.

          Matt questioned whether Dojo client-side validation works with this component. It has worked in previous versions.
          James Gates made changes -
          Description Matt Raible found this problem with the 4.1.3-SNAPSHOT release and reported it on the mailing list, but I didn't see a JIRA issue for it: http://www.nabble.com/Re%3A-Validation-and-CSS-with-4.1.3-SNAPSHOT-p12397222.html. The behavior is still there in this build.

          The client-side validation code produces an empty popup when you submit a form if the form contains a PropertySelection component with validators. Here's the example from Matt's message:

              <component id="countryField" type="PropertySelection">
                  <binding name="model" value="countries"/>
                  <binding name="value" value="user.address.country"/>
                  <binding name="validators" value="validators:required"/>
                  <binding name="displayName" value="message:user.address.country"/>
              </component>

          You get the blank popup appears even when the validation should pass (i.e., the field has a selected option). As a test I created an alternative required validator that decorates the markup but doesn't generate any validation on the client, and that one doesn't exhibit this behavior. The problem appears to lie either in changes to Dojo's "required" validation in this release or in how Tapestry is using it.

          Matt questioned whether Dojo client-side validation works with this component. It has worked in previous versions.
          Matt Raible found this problem with the 4.1.3-SNAPSHOT release and reported it on the mailing list, but I didn't see a JIRA issue for it: http://www.nabble.com/Re%3A-Validation-and-CSS-with-4.1.3-SNAPSHOT-p12397222.html. The behavior is still there in this build.

          The client-side validation code produces an empty popup when you submit a form if the form contains a PropertySelection component with validators. Here's the example from Matt's message:

              <component id="countryField" type="PropertySelection">
                  <binding name="model" value="countries"/>
                  <binding name="value" value="user.address.country"/>
                  <binding name="validators" value="validators:required"/>
                  <binding name="displayName" value="message:user.address.country"/>
              </component>

          You get the blank popup even when the validation should pass (i.e., the field has a selected option). As a test I created an alternate required validator that decorates the markup but doesn't generate any validation on the client, and that one doesn't exhibit this behavior. The problem appears to lie either in changes to Dojo's "required" validation in this release or in how Tapestry is using it.

          Matt questioned whether Dojo client-side validation works with this component. It has worked in previous versions.
          James Gates made changes -
          Summary Blank validation popup with PropertySelection on form submission Client-side validation is broken for PropertySelection
          James Gates made changes -
          Fix Version/s 4.1.4 [ 12312763 ]
          Geoff Callender made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          Jesse Kuhnert made changes -
          Assignee Jesse Kuhnert [ jkuhnert ]
          Jesse Kuhnert made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Marcus Schulte made changes -
          Link This issue is duplicated by TAPESTRY-1806 [ TAPESTRY-1806 ]
          Marcus Schulte made changes -
          Link This issue relates to TAPESTRY-1663 [ TAPESTRY-1663 ]
          Mark Thomas made changes -
          Workflow jira [ 12413083 ] Default workflow, editable Closed status [ 12568359 ]
          Mark Thomas made changes -
          Workflow Default workflow, editable Closed status [ 12568359 ] jira [ 12590065 ]

            People

            • Assignee:
              Jesse Kuhnert
              Reporter:
              James Gates
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development