Tapestry
  1. Tapestry
  2. TAPESTRY-1730

Order of event handler method invocation should be greatest number of parameters to fewest

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.5
    • Fix Version/s: 5.0.6
    • Component/s: tapestry-core
    • Labels:
      None

      Description

      Say you are writing an activate event handler, meant to guard the page against access without a provided token.

      void onActivate(String token) {
      // validate the token
      }

      Object onPassivate()

      { return _token; }

      Great ... but what about the case where the user omits the token?

      Object onActivate() {
      return _invalidAuthorizationPage; // Redirect away
      }

      But with the current setup, this gets invoked BEFORE onActivate(String) so there's no hope of actually using the page, even with the security token.

        Activity

        Mark Thomas made changes -
        Workflow Default workflow, editable Closed status [ 12568081 ] jira [ 12591178 ]
        Mark Thomas made changes -
        Workflow jira [ 12411940 ] Default workflow, editable Closed status [ 12568081 ]
        Howard M. Lewis Ship made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Fix Version/s 5.0.6 [ 12312544 ]
        Howard M. Lewis Ship made changes -
        Field Original Value New Value
        Assignee Howard M. Lewis Ship [ hlship ]
        Howard M. Lewis Ship created issue -

          People

          • Assignee:
            Howard M. Lewis Ship
            Reporter:
            Howard M. Lewis Ship
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development